Proposal: use an entrypoint

[evantill]

Hi,

Thank you for this docker image 👍.

Using an ENTRYPOINT when wrapping a cli tool using a docker image ease the use of the image

Example of an article that will explain it better than me https://spin.atomicobject.com/2015/11/30/command-line-tools-docker/

By using an ENTRYPOINT, all of the arguments to docker run following our image name are passed as arguments to our application.

I will be happy to make a PR if you agrre with this proposal.

Please let me know if you have any questions or concerns about this proposal.

[woile]

Sure, go ahead. Thanks

[evantill]

it will break the v2 convention. Maybe a goot idea to increase the major version

For example in the workflow :

commitizen-docker-image/.github/workflows/publish-container.yml

Line 52 in 601902c

commitizen/commitizen:2

[evantill]

In script/build:

commitizen-docker-image/scripts/build

Line 8 in 601902c

-t registry.hub.docker.com/commitizen/commitizen:2 \

In scripts/run:

commitizen-docker-image/scripts/run

Line 2 in 601902c

docker run --rm --name commitizen registry.hub.docker.com/commitizen/commitizen:2 /bin/sh -c "$@"

[evantill]

And in the readme:

commitizen-docker-image/README.md

Lines 11 to 17 in 601902c

	We publish major versions starting with `v2` + latest exact v2.
	| Tag | Description |
	| ------------------------------ | --------------------------------------------------------------- |
	| `commitizen/commitizen:latest` | Latest major version, at the moment v2 |
	| `commitizen/commitizen:2` | Points to latest v2 |
	| `commitizen/commitizen:2.x` | See [tags](https://hub.docker.com/r/commitizen/commitizen/tags) |

[woile]

It would break it in what way? The way it's used?

[evantill]

Yes in the way it is used

Before:

docker run --rm -v $(pwd):/app commitizen/commitizen:latest /bin/sh -c 'cz bump --changelog'

After:

docker run --rm -v $(pwd):/app commitizen/commitizen:latest bump --changelog

[evantill]

That why I propose to update the main master branch for a V3 release.

[evantill]

I see 2 options here:

1. Update V2 references to V3 in the code
2. Remove hardcoded references to the version

[woile]

This is the way now