Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Latest versioned docker image is getting overwritten daily #9

Closed
@Tommyf

Description

@Tommyf

The latest docker image is getting published daily by the GitHub actions, even if there is no release.

While the underlying build of the image has not changed, it does not inspire confidence when you see that the image is constantly being updated.

Currently, https://hub.docker.com/r/commitizen/commitizen/tags is showing that the following tags were updated 12 hours ago (Nov 8th 2022), even though the last release was 12 days ago (Oct 28th 2022).
Tags:

  • latest
  • 2.37.0
  • 2

The 2.35.0 tag shows as last updated on Oct 28th, even though it was released on Sep 12th as this is when the daily update stopped for that version. It's confusing for anyone looking and trying to verify the current image.

Tags for specific versions should be immutable - or at least you should not mutate them. Rolling tags are fine for latest, or major/minor specific tags, (e.g. 2, 2.37), the tags for specific versions should remain unchanged.

Even when rolling tags, they should only be updated when there is an actual underlying version change. By doing it daily, regardless of any changes, you introduce the problem that upstream problems could propagate into your images, that should not be changing.

For example, let's say your upstream image, python:3-alpine, changes. This is a rolling tag, so changes are expected. If this introduces a breaking change (It should not, but it could), then your images are now broken and any pipelines that depend on them may fail unexpectedly.

These problems can be super hard to track down - have done it many times :)

Summary of issue:

  • Don't rebuild & push images daily, unless there is a new version released
  • Don't allow specific version tags to be updated (Though I think in your case, this will be automatically fixed by the first point)

Note: I am not actually affected by this right now, just trying to help :). If needed, I can try to submit a PR for this later on if you need help trying to fix this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions