Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

option to specify newline types #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CanisHelix opened this issue Mar 8, 2022 · 2 comments
Closed

option to specify newline types #492

CanisHelix opened this issue Mar 8, 2022 · 2 comments

Comments

@CanisHelix
Copy link

Description

I have pre-commit hooks to enforce LF line endings, this fails on every commitizen commit as it writes CRLF on windows. An option to configure this would be good.

Possible Solution

Hacky, but I have customized my local commitizen and found all instances of open and added newline='\n' to them if they are w opens. And option in the .cz.yaml to specify this would be the optimal method.

Additional context

No response

Additional context

No response

@CanisHelix CanisHelix added the type: feature A new enhacement proposal label Mar 8, 2022
@Lee-W
Copy link
Member

Lee-W commented Mar 13, 2022

@woile I'm good with it and think it might be helpful. What do you think?

pan93412 added a commit to pan93412/commitizen that referenced this issue Mar 13, 2022
Follow the configuration of `core.eof` in Git.

Close commitizen-tools#492
pan93412 added a commit to pan93412/commitizen that referenced this issue Mar 13, 2022
Determine the newline character to write with `git config core.eof`.

Close commitizen-tools#492
@woile
Copy link
Member

woile commented Mar 13, 2022

I'm also good with it as an option in the configuration

pan93412 added a commit to pan93412/commitizen that referenced this issue Aug 10, 2022
Determine the newline character to write with `git config core.eof`.

Close commitizen-tools#492
pan93412 added a commit to pan93412/commitizen that referenced this issue Aug 10, 2022
Determine the newline character to write with `git config core.eof`.

Close commitizen-tools#492
pan93412 added a commit to pan93412/commitizen that referenced this issue Aug 10, 2022
Determine the newline character to write with `git config core.eof`.

Close commitizen-tools#492
pan93412 added a commit to pan93412/commitizen that referenced this issue Aug 10, 2022
Determine the newline character to write with `git config core.eof`.

Close commitizen-tools#492
@Lee-W Lee-W closed this as completed in 644675b Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants