-
-
Notifications
You must be signed in to change notification settings - Fork 286
refactor(check): rename variable and compile pattern once #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: refactors
Are you sure you want to change the base?
refactor(check): rename variable and compile pattern once #1470
Conversation
eac0d6f
to
37d65a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1470 +/- ##
==========================================
Coverage 97.82% 97.82%
==========================================
Files 57 57
Lines 2619 2619
==========================================
Hits 2562 2562
Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
37d65a2
to
0b02dbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm somewhat worried about this one. I guess there might been users actually use the message to check. Probably could make it a deprecated thing and change in v5
Then let me revert the |
0b02dbd
to
a53ef4d
Compare
a53ef4d
to
7a5dfb9
Compare
Fixed. You meant the error message, right? |
Description
Checklist
Code Changes
poetry all
locally to ensure this change passes linter check and testsExpected Behavior
Steps to Test This Pull Request
Run
cz check --message "<random strings>"
to check if the error message works like before.Additional Context