Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

fix(cz_customize): make schema_pattern customizable through config for cz_customize #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Oct 4, 2020

Description

make schema_pattern customizable through config for cz_customize

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

configure schema_pattern in the configuration file should make cz check work for cz_customize

Steps to Test This Pull Request

  1. cz init (Choose cz_customize)
  2. add schema_pattern to configuration file
  3. run cz check

Additional context

#273

@Lee-W Lee-W requested a review from woile October 4, 2020 04:29
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #276 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   96.61%   96.63%   +0.02%     
==========================================
  Files          33       33              
  Lines         915      921       +6     
==========================================
+ Hits          884      890       +6     
  Misses         31       31              
Flag Coverage Δ
#unittests 96.63% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/check.py 100.00% <100.00%> (ø)
commitizen/cz/customize/customize.py 93.61% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e9bad...5b56b7e. Read the comment docs.

@woile woile merged commit 2136ed5 into master Oct 4, 2020
@woile woile deleted the add-schema_pattern-to-cz_customize branch October 4, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants