Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

fix(config): change read mode from r to rb #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

loonghao
Copy link

@loonghao loonghao commented Feb 21, 2021

This MR is fix #349

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #353 (4671258) into master (1605d69) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files          35       35           
  Lines         999      999           
=======================================
  Hits          972      972           
  Misses         27       27           
Flag Coverage Δ
unittests 97.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/config/__init__.py 100.00% <100.00%> (ø)
commitizen/config/base_config.py 100.00% <100.00%> (ø)
commitizen/config/json_config.py 100.00% <100.00%> (ø)
commitizen/config/toml_config.py 100.00% <100.00%> (ø)
commitizen/config/yaml_config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2387ea7...4671258. Read the comment docs.

@woile woile merged commit 3a4d13f into commitizen-tools:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to read configuration containing Chinese words
2 participants