Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Bump: support manual version #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Bump: support manual version #591

merged 4 commits into from
Sep 19, 2022

Conversation

jakob-keller
Copy link
Contributor

Description

Closes #435

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

cz bump 1.2.3 uses 1.2.3 as new version

Steps to Test This Pull Request

Additional context

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Base: 98.38% // Head: 98.40% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (2ba0b73) compared to base (f6ab845).
Patch coverage: 96.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
+ Coverage   98.38%   98.40%   +0.01%     
==========================================
  Files          39       39              
  Lines        1614     1634      +20     
==========================================
+ Hits         1588     1608      +20     
  Misses         26       26              
Flag Coverage Δ
unittests 98.40% <96.77%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/cli.py 93.93% <ø> (ø)
commitizen/commands/bump.py 97.03% <96.29%> (+0.42%) ⬆️
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/exceptions.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jakob-keller
Copy link
Contributor Author

Not sure, why these tests fail. Anything I need to fix?

@Lee-W Lee-W closed this Sep 18, 2022
@Lee-W Lee-W reopened this Sep 18, 2022
@woile
Copy link
Member

woile commented Sep 19, 2022

Tests are not failing, it is the coverage report. But I'm not sure why it's decreasing, it doesn't look like it's decreasing

@Lee-W
Copy link
Member

Lee-W commented Sep 19, 2022

Tests are not failing, it is the coverage report. But I'm not sure why it's decreasing, it doesn't look like it's decreasing

Sometimes I just don't understand codecov 🤔

Copy link
Member

@woile woile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice feature!

@woile woile merged commit 8dcfac0 into commitizen-tools:master Sep 19, 2022
@jakob-keller jakob-keller deleted the bump/manual-version branch September 19, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually bump entire version, not just manually specify which part to increment
3 participants