-
-
Notifications
You must be signed in to change notification settings - Fork 281
test(warnings): switch from the unmaintained pytest-freezegun
to pytest-freezer
removing warnings
#639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v3 #639 +/- ##
=====================================
Coverage ? 98.42%
=====================================
Files ? 39
Lines ? 1655
Branches ? 0
=====================================
Hits ? 1629
Misses ? 26
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @noirbizarre !
@woile I'm planning on merging it this week. Let me know if you want to take a deeper look. Thanks!
@noirbizarre I'm thinking maybe we could send this PR directly to main instead of v3. We could rebase it back to v3 later. What do you think? |
Except for the lockfile part, it can be sent to |
I think we can do the relock for main and relock again after rebasing to v3. What do you think? |
I say that because we don't have a lock yet on
|
Backported in #643 but I realised that given test fixes are not on |
I just merge #643 back to main. Once main is updated, you can update your local main and rebase it back to your feature branch and than force push to this branch. Thanks for the prompt PR! |
Thanks ! |
indeed. I forget that 😱 let me do so now! |
7bd4fc2
to
66405ee
Compare
Thanks, updated. But I think your working copy was not up to date and #638 is missing from the rebased |
yep.... do you still have the branch on your local? |
No but I just restored it on github in the PR #638 |
ah yes, we could do that. I just push that back to v3 |
…ytest-freezer` removing warnings
66405ee
to
15162a3
Compare
And this is properly rebased on |
Description
Switch from
pytest-freezegun
which is not maintained anymore and stuck on a legacyfreezegun
version raising lots of warnings topytest-freezer
its maintained fork by the officialpytest-dev
github organization which is maintained and up to date, raises no warnings and provide typing.Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testExpected behavior
No behavior change expected.
Test should still pass but the 2662 warnings raised should have disappeared.
Steps to Test This Pull Request
Run the test suite
Additional context
Dependency change so the dependencies have been re-locked