-
-
Notifications
You must be signed in to change notification settings - Fork 286
test: add test for 'additional' types in conventional commits #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
==========================================
- Coverage 97.38% 97.34% -0.05%
==========================================
Files 42 42
Lines 2029 2034 +5
==========================================
+ Hits 1976 1980 +4
- Misses 53 54 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
6521f0b
to
2750a51
Compare
2750a51
to
8bfc98d
Compare
|
||
|
||
- drop support for py36 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of this @Lee-W @jenstroeger ?
It won't show the title ### BREAKING CHANGE
. But it's the best I could do with the new regex, I cannot repeat the breaking
group in here:
041d5bb
to
4eae67a
Compare
4eae67a
to
376427c
Compare
Description
This tests should pass, relates to:
#673
Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and test