[ub] a few more fixes #7888
Open
[ub] a few more fixes #7888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsutter
approved these changes
May 24, 2025
shafik
approved these changes
May 28, 2025
| void *p = malloc(sizeof(int) + sizeof(float)); // undefined behavior, cannot create | ||
| // both int and float in same place | ||
| int& i = *reinterpret_cast<int*>(p); | ||
| float& f = *reinterpret_cast<float*>(p); |
There was a problem hiding this comment.
Wouldn't this be the point of UB?
CC @jensmaurer
There was a problem hiding this comment.
Yes, the "malloc" is fine. The comment needs to move to line 34.
| @@ -123,78 +127,184 @@ | |||
| }; | |||
|
|
|||
| float f() { | |||
There was a problem hiding this comment.
Suggested change
| float f() { | |
| void f() { |
| \pnum | ||
| \begin{example} | ||
| \begin{codeblock} | ||
| int main() { |
There was a problem hiding this comment.
These next two examples are over indented, was that on purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks up some
\ubdefentries in the UB annex into multiple, more granular entries, for those cases of UB where there is value in distinguishing them. This PR makes the list of UB in theub-ifndrbranch identical to the list of UB provided in Appendix A of P3100R2.