Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove matmul_H from gru.md #2351

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Remove matmul_H from gru.md #2351

merged 1 commit into from
Nov 21, 2022

Conversation

gab-chen
Copy link
Contributor

@gab-chen gab-chen commented Nov 20, 2022

Description of changes:
The lambda function matmul_H is not used anywhere of the entire book, let alone the GRUScratch implementation.
See the search result of the function name.
https://d2l.ai/search.html?q=matmul_H&check_keywords=yes&area=default

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

@gab-chen
Copy link
Contributor Author

The pr-merge has a HTTPConnection error.

@astonzhang
Copy link
Member

@d2l-bot please rebuild.

1 similar comment
@gab-chen
Copy link
Contributor Author

@d2l-bot please rebuild.

@d2l-bot
Copy link
Member

d2l-bot commented Nov 21, 2022

Job d2l-en/PR-2351/4 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2351/

Copy link
Member

@AnirudhDagar AnirudhDagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@AnirudhDagar AnirudhDagar merged commit ef1c833 into d2l-ai:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants