feat: add pagination for all GET apis' of git providers

[abhishek818]

Enhancement: add pagination for all GET apis' of git providers (#761)

Description

Almost every GET api results have been limited by a value of 100 items. Hence, we must enable pagination.

• This change requires a documentation update
• I have made corresponding changes to the documentation

Related Issue(s)

This PR addresses issue #761
closes #761
/claim #761

Screenshots

If relevant, please add screenshots.

Notes

Please add any relevant notes if necessary.

[abhishek818]

@Tpuljak @idagelic Up for review.

PS: I had added pagination (for bitbucketserver) when I implemented bitbucketserver support. 😏 :p

[abhishek818]

I dont think we will require rate limiting here, but who knows. There are always some extreme users..
Open to suggestions obviously.

[Tpuljak]

@Tpuljak @idagelic Up for review.

As I said, no need for tagging us separately cause we automatically get 3 emails per PR 😄

Your solution by itself does not influence nor solve #761 since the pagination can not be used. The scope of solving this issue is not only to add pagination to git providers on the backend, but to expose that functionality via the API and make the TUI lists paginate properly.

I'll place the PR in draft since you did part of the work on the backend. Mark it for review when you applied the required changes or let us know if you don't want to continue solving this.

[abhishek818]

do you mean adding pagination for frontend TUI here?

func selectRepositoryPrompt(repositories []apiclient.GitRepository, index int, choiceChan chan<- string, parentId string, selectedReposParentMap map[string]bool, selectedRepos map[string]bool) {
	items := []list.Item{}
	disabledReposCount := 0

	// Populate items with titles and descriptions from workspaces.
	for _, repository := range repositories {         <-------------------------
		url := *repository.Url
		title := *repository.Name
		isDisabled := false

                .....
		newItem := item[string]{id: url, title: title, choiceProperty: url, desc: url, isDisabled: isDisabled}
		items = append(items, newItem)
	}

      ......
	l := views.GetStyledSelectList(items)

}

Or support an argument like 'page' which comes from the backend and then applying pagination?
providerRepos, _, err = apiClient.GitProviderAPI.GetRepositories(ctx, providerId, namespaceId, page).Execute() <---------

[Tpuljak]

@abhishek818 both 😄

In order for the TUI pagination to work, you need to implement it on the API as well.

[abhishek818]

update: if not urgently needed to be merged, will come back to this after a couple of days.

[abhishek818]

I am back since you guys posted many bounties lol!

[abhishek818]

@Tpuljak closed? this pr is related to another issue..

[lbrecic]

Hi @abhishek818 !
So sorry for this inconvenience on our part, the issue and the PR number similarity (766 & 776) got the best of us in the referenced merged PR #809 😅
You can continue with your development!

[abhishek818]

Up for review!

[abhishek818]

Similar changes needed for get branches, namespaces etc. but want to confirm first since this is a api signature change..

[Tpuljak]

@abhishek818 the direction seems good but I see that a check is failing. Please address that and my comment below.

From what I can see, this direction is good and you can implement it for other methods as well. I'll place the PR in draft.

[abhishek818]

can you help with the swagger error? Everytime I make the suggested changes, it fails with a different change. Tried running hack/swagger.sh file..

[Tpuljak]

/tip $50

[algora-pbc]

🎉🎈 @abhishek818 has been awarded $50! 🎈🎊

• Share on socials
• Give feedback