Prevent false nicknames due to multiple quotes#86
Merged
derek73 merged 1 commit intoderek73:masterfrom Jun 27, 2019
vaneseltine:improve-single-quote-handling
Merged
Prevent false nicknames due to multiple quotes#86derek73 merged 1 commit intoderek73:masterfrom vaneseltine:improve-single-quote-handling
derek73 merged 1 commit intoderek73:masterfrom
vaneseltine:improve-single-quote-handling
Conversation
Certain Anglicized names such as those from some Hawaiian, Samoan, and Kenyan traditions, include multiple single quotation marks. This adjusts the quoted_word regex to only capture single quote marks that are not inside words. Without this fix, false nicknames are extracted from inside names like Ng'ang'a and Kawai'ae'a. Tests are included to cover; existing Benjamin 'Ben' Franklin test assures that the typical nickname case is unchanged.
Owner
|
Thanks for the great pull request. I knew this wasn't quite right but didn't know how to fix it. My regex mojo is pretty weak. I appreciate the help. |
Contributor
Author
|
Happy to help, and thank you for building and maintaining nameparser. I'm getting good use out of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain Anglicized names such as those from some Hawaiian, Samoan,
and Kenyan traditions, include multiple single quotation marks.
This adjusts the quoted_word regex to only capture single quote
marks that are not inside words. Without this fix, false nicknames
are extracted from inside names like Ng'ang'a and Kawai'ae'a.
Tests are included to cover; existing Benjamin 'Ben' Franklin test
assures that the typical nickname case is unchanged.