Proposing a new implementation for Range encoding #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 8, 2018 14:18
The previous implementation was encoding a range as a list of possible
values. This is not a viable approach, as it can possibly lead to huge
messages.
The new implementation treats a range as it is: a map, with a :first and
a :last fields. Thus, the resulting bitstring of Poison.encode(a..b) is
the same as Poison.encode(%{first: a, last: b}).
Pull Request Test Coverage Report for Build 240
💛 - Coveralls |
29a475d
to
e0a080a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
EncoderforRangewas putting all the possible elements into a list, so1..10resulted in[1,2,3,4,5,6,7,8,9,10], and likewise,1..999999999would produce a huge message (which would actually freeze your computer).The implementation I'm proposing simply treats a range as its underlying map, with a
:firstand a:lastfields.