[GraphBolt][CUDA] Incremental GPU graph cache into `gb.Dataloader`. #7475

mfbalin · 2024-06-25T04:34:08Z

Description

Depends on #7470 and cpp changes were moved to #7483.

Checklist

Please feel free to remove inapplicable items for your PR.

The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
I've leverage the tools to beautify the python and c++ code.
The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
All changes have test coverage
Code is well-documented
To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
Related issue is referred in this PR
If the PR is for a new model/paper, I've updated the example index here.

Changes

dgl-bot · 2024-06-25T04:34:33Z

To trigger regression tests:

@dgl-bot run [instance-type] [which tests] [compare-with-branch];
For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

dgl-bot · 2024-06-25T04:36:18Z

Commit ID: 40d6e841c8a3cf9db266bff53c2382eb840c4be2

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

dgl-bot · 2024-06-25T04:50:19Z

Commit ID: 61294c44603fa891c6600b8199f45b6b295b10e1

Build ID: 2

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

python/dgl/graphbolt/dataloader.py

python/dgl/graphbolt/impl/neighbor_sampler.py

dgl-bot · 2024-06-26T03:22:57Z

Commit ID: c21735d

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot · 2024-06-26T03:32:51Z

Commit ID: ee84274

Build ID: 4

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

dgl-bot · 2024-06-26T05:37:41Z

Commit ID: 54a594a

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot · 2024-06-26T06:08:35Z

Commit ID: 71f4a6c

Build ID: 6

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

dgl-bot · 2024-06-26T06:56:16Z

Commit ID: 48a2bf2

Build ID: 7

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

dgl-bot · 2024-06-26T07:39:22Z

Commit ID: 7bdd685

Build ID: 8

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot · 2024-06-26T10:07:30Z

Commit ID: 44c0aa9

Build ID: 9

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

mfbalin · 2024-06-26T10:09:24Z

@dgl-bot
@Rhett-Ying CI still failing

mfbalin · 2024-06-26T10:10:11Z

@dgl-bot

dgl-bot · 2024-06-26T10:43:23Z

Commit ID: 44c0aa9

Build ID: 10

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot · 2024-06-26T16:52:15Z

Commit ID: ef03812

Build ID: 11

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot · 2024-06-26T16:57:50Z

Commit ID: d543580

Build ID: 12

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot · 2024-06-26T17:28:27Z

Commit ID: b89e81a8b672a6696861f700e2c22f9390973f74

Build ID: 13

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

mfbalin · 2024-06-26T17:55:33Z

@dgl-bot

dgl-bot · 2024-06-26T18:26:17Z

Commit ID: ddb369b96b5e32a28a160f6745f3c89d80d02e57

Build ID: 14

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

mfbalin · 2024-06-26T18:29:58Z

@dgl-bot

dgl-bot · 2024-06-26T19:02:43Z

Commit ID: c93ca18dc54a32aa4f0079707337a624235556ca

Build ID: 15

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

mfbalin · 2024-06-26T19:03:46Z

@dgl-bot

mfbalin · 2024-06-26T19:04:15Z

tests/distributed/test_partition.py::test_partition[None-True-1-4-metis] Converting to homogeneous graph takes 0.001s, peak mem: 2.438 GB
Convert a graph into a bidirected graph: 0.000 seconds, peak memory: 2.438 GB
Construct multi-constraint weights: 0.000 seconds, peak memory: 2.438 GB
Fatal Python error: Segmentation fault

Thread 0x00007f30deedf700 (most recent call first):
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/threading.py", line 324 in wait
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/threading.py", line 607 in wait
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/tqdm/_monitor.py", line 60 in run
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/threading.py", line 1016 in _bootstrap_inner
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/threading.py", line 973 in _bootstrap

Current thread 0x00007f310bbe5800 (most recent call first):
  File "/home/ubuntu/jenkins/workspace/dgl_PR-7475@2/python/dgl/partition.py", line 385 in metis_partition_assignment
  File "/home/ubuntu/jenkins/workspace/dgl_PR-7475@2/python/dgl/distributed/partition.py", line 1001 in partition_graph
  File "/home/ubuntu/jenkins/workspace/dgl_PR-7475@2/tests/distributed/test_partition.py", line 354 in check_partition
  File "/home/ubuntu/jenkins/workspace/dgl_PR-7475@2/tests/distributed/test_partition.py", line 532 in test_partition
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/python.py", line 162 in pytest_pyfunc_call
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/python.py", line 1627 in runtest
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/runner.py", line 173 in pytest_runtest_call
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/runner.py", line 241 in &lt;lambda&gt;
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/runner.py", line 341 in from_call
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/runner.py", line 240 in call_and_report
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/runner.py", line 135 in runtestprotocol
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/runner.py", line 116 in pytest_runtest_protocol
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/main.py", line 364 in pytest_runtestloop
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/main.py", line 339 in _main
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/main.py", line 285 in wrap_session
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/main.py", line 332 in pytest_cmdline_main
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/config/__init__.py", line 178 in main
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/_pytest/config/__init__.py", line 206 in console_main
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/site-packages/pytest/__main__.py", line 7 in &lt;module&gt;
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/runpy.py", line 86 in _run_code
  File "/opt/conda/envs/pytorch-ci/lib/python3.10/runpy.py", line 196 in _run_module_as_main

dgl-bot · 2024-06-26T19:37:49Z

Commit ID: 0d63781ba5ff33b3af3eb15d5a06a8bc004a4629

Build ID: 16

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

[GraphBolt][CUDA] Incremental GPU graph cache into gb.Dataloader.

e013ab6

mfbalin requested a review from frozenbugs June 25, 2024 04:34

add missing docstring for linting

eaa965e

frozenbugs reviewed Jun 26, 2024

View reviewed changes

python/dgl/graphbolt/dataloader.py Outdated Show resolved Hide resolved

python/dgl/graphbolt/impl/neighbor_sampler.py Outdated Show resolved Hide resolved

mfbalin added 2 commits June 25, 2024 23:12

Merge branch 'master' into gb_cuda_gpu_graph_cache_py

c21735d

better variable naming, add docs

ee84274

frozenbugs approved these changes Jun 26, 2024

View reviewed changes

mfbalin added the Release Candidate Candidate PRs for the upcoming release label Jun 26, 2024

mfbalin added 2 commits June 26, 2024 01:26

Merge branch 'master' into gb_cuda_gpu_graph_cache_py

54a594a

fix dataloader parameter names.

71f4a6c

mfbalin changed the title ~~[GraphBolt][CUDA] Incremental GPU graph cache into gb.Dataloader.~~ [GraphBolt][CUDA][DO NOT MERGE] Incremental GPU graph cache into gb.Dataloader. Jun 26, 2024

mfbalin changed the title ~~[GraphBolt][CUDA][DO NOT MERGE] Incremental GPU graph cache into gb.Dataloader.~~ [GraphBolt][CUDA] Incremental GPU graph cache into gb.Dataloader. Jun 26, 2024

mfbalin changed the title ~~[GraphBolt][CUDA] Incremental GPU graph cache into gb.Dataloader.~~ [GraphBolt][CUDA][DO NOT MERGE] Incremental GPU graph cache into gb.Dataloader. Jun 26, 2024

Merge branch 'master' into gb_cuda_gpu_graph_cache_py

48a2bf2

Merge branch 'master' into gb_cuda_gpu_graph_cache_py

7bdd685

Fix the segmentation fault and add extra runtime checks.

44c0aa9

mfbalin changed the title ~~[GraphBolt][CUDA][DO NOT MERGE] Incremental GPU graph cache into gb.Dataloader.~~ [GraphBolt][CUDA] Incremental GPU graph cache into gb.Dataloader. Jun 26, 2024

mfbalin requested a review from frozenbugs June 26, 2024 09:41

mfbalin mentioned this pull request Jun 26, 2024

[GraphBolt][CUDA] Demonstrate GPUGraphCache usage in example. #7482

Merged

8 tasks

mfbalin added 3 commits June 26, 2024 16:47

take back cpp changes

13539eb

lint

ef03812

take back cpp changes

d543580

mfbalin mentioned this pull request Jun 26, 2024

[CI] Spurious test failures #7481

Open

mfbalin merged commit 95dc96a into dmlc:master Jun 26, 2024
2 checks passed

mfbalin deleted the gb_cuda_gpu_graph_cache_py branch June 26, 2024 19:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GraphBolt][CUDA] Incremental GPU graph cache into `gb.Dataloader`. #7475

[GraphBolt][CUDA] Incremental GPU graph cache into `gb.Dataloader`. #7475

mfbalin commented Jun 25, 2024 •

edited

Loading

dgl-bot commented Jun 25, 2024

dgl-bot commented Jun 25, 2024

dgl-bot commented Jun 25, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

[GraphBolt][CUDA] Incremental GPU graph cache into gb.Dataloader. #7475

[GraphBolt][CUDA] Incremental GPU graph cache into gb.Dataloader. #7475

Conversation

mfbalin commented Jun 25, 2024 • edited Loading

Description

Checklist

Changes

dgl-bot commented Jun 25, 2024

dgl-bot commented Jun 25, 2024

dgl-bot commented Jun 25, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

mfbalin commented Jun 26, 2024

mfbalin commented Jun 26, 2024

dgl-bot commented Jun 26, 2024

[GraphBolt][CUDA] Incremental GPU graph cache into `gb.Dataloader`. #7475

[GraphBolt][CUDA] Incremental GPU graph cache into `gb.Dataloader`. #7475

mfbalin commented Jun 25, 2024 •

edited

Loading