-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undeprecate PARTIAL for array hydration. #11366
Undeprecate PARTIAL for array hydration. #11366
Conversation
Please update UPGRADE.md as well 🙏 |
Shouldn't we target 2.20 for this? |
The base branch was changed.
We made forward compatibility improvements in mini versions in DBAL, so I an with @greg0ire here that this can be in 2.19 |
But that's not what we agreed on in #11208. |
@derrabus I think it would qualify as an improvement if there was something that should be deprecated but wasn't. Here, we are wrongly over-deprecating, causing extra work. Just like static analysis tags can be imprecise and wrong and static analysis changes can go on patch or minor depending on whether they make things more accurate or more precise, this change is about making the deprecation more accurate. When #11365, the deprecation will become wrong, hence this is a bugfix, and complies with #11208 IMO, although I must admit it feels like an edge case/ gray area stuff, because it's correct today, and will suddenly become wrong tomorrow. This relates to doctrine/doctrine-website#485 |
Yes |
Pair for #11365
Related: