Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] Re-add TRAHA Global config #3936

Closed
wants to merge 1 commit into from
Closed

Conversation

Die4Ever
Copy link

@Die4Ever Die4Ever commented Apr 4, 2024

Although not likely, it is possible the game could come back (either officially or through private servers)

If we maintain an archive of all old and dead games, then they can be brought back to life with DXVK taking care of compatibility. Especially old games can benefit from DXVK even on Windows (we use it by default in Deus Ex Randomizer).

If the game is brought back through unofficial means, it could become legally difficult to explain why we added back their config code for an unofficial release. But if we decide to be an archive and keep these configs forever, then there's no legal concern because we're just acting as an archive/historical reserve.

discussion here 855b274#commitcomment-140395860

Die4Ever referenced this pull request Apr 4, 2024
This game apparently no longer exists.
@Blisto91
Copy link
Contributor

Blisto91 commented Apr 4, 2024

Just as a quick note this game didn't work with dxvk on Windows because of anti cheat

@Die4Ever
Copy link
Author

Die4Ever commented Apr 4, 2024

Just as a quick note this game didn't work with dxvk on Windows because of anti cheat

well if it was revived in the future it might not have anticheat anymore (officially if they don't want to pay for the licensing? or unofficially obviously a private server could exclude it), or the anticheat might change

but just working on Linux is already a good thing, obviously, especially as Linux is still getting more popular

@gabriele2000
Copy link

gabriele2000 commented Apr 4, 2024

Just as a quick note this game didn't work with dxvk on Windows because of anti cheat

Why was it present as a per-game config then?

Also, DXVK is a wrapper, I don't think it's "our" business to care about the state of the game.
A custom fix is needed for it to execute properly.
We keep that.

One could pirate the game too, and it's none of our concern.
The end user can use something thanks to a known custom config, mission accomplished.

Like WINE, DXVK shall do the job to translate DX into Vulkan, nothing more.

@Blisto91
Copy link
Contributor

Blisto91 commented Apr 4, 2024

Why was it present as a per-game config then?

Because it could run with dxvk on Linux.

@gabriele2000
Copy link

Because it could run with dxvk on Linux.

Exactly.
It could stll run, the game technically still exists and as I said, there are other means to make it work.

It a few lines of text, what's the downsides of keeping something possibly useful?

@doitsujin
Copy link
Owner

I don't really see a point to do this based on a what-if scenario. If the game ever gets revived in one way or another we can talk about it, but for the time being it's deadweight that we literally cannot test.

@Die4Ever
Copy link
Author

Die4Ever commented Apr 5, 2024

I don't really see a point to do this based on a what-if scenario. If the game ever gets revived in one way or another we can talk about it, but for the time being it's deadweight that we literally cannot test.

If the game gets revived through unofficial means then it could legally be pointed out that the reason we brought back support for the game was only to support that unofficial release, it could be similar to Yuzu/Citra

If we put this in now then it's obvious that we just want to act as an archive for compatibility/preservation with every game possible

If bugs with the game are found in the future then they can be fixed, as long as we do this now to show our intent of being an archive

@Tiagoquix
Copy link
Contributor

I don't think it's a good idea to delete fixes for games that no longer work. Maybe they will in the future again.

For example:

/* Garden Warfare 2
Won't start on amd Id without atiadlxx */
{ R"(\\GW2\.Main_Win64_Retail\.exe$)", {{
{ "dxgi.customVendorId", "10de" },
}} },

The above code is useless because the game now has a new anti-cheat developed by EA and thus the game no longer works on Linux due to Wine not being supported by the anti-cheat. But maybe in the future they will change their minds and make it work. We don't know.

Or maybe, somehow, a user has a physical copy of a game that is no longer sold online, or maybe that was in the past but is no longer the case, then the fix should be kept.

@doitsujin doitsujin closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants