[6.x.x] Fix a memory leak in the XPath 3.1 Arrow Operator implementation#175
Open
adamretter wants to merge 4 commits intodevelop-6.x.xfrom
Open
[6.x.x] Fix a memory leak in the XPath 3.1 Arrow Operator implementation#175adamretter wants to merge 4 commits intodevelop-6.x.xfrom
adamretter wants to merge 4 commits intodevelop-6.x.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #174
The Arrow Operator implementation previously did not free the reference to the Context Sequence on its left-side. This meant that it would be kept in-memory if the compiled query was sent to the XQuery Pool for reuse. This PR fixes that issue so that the memory is correctly freed when the query completes execution. Additionally there was also a possible resource leak if a Function Reference provided to the Arrow Operator was not of the expected cardinality, that is now fixed as well.