-
Notifications
You must be signed in to change notification settings - Fork 47.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use ES modules internally #10524
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cool! How did you convert if (__DEV__) {
var warning = require('warning');
} ? |
27,000 deletions. Why such a stark drop? |
It's stacked (ha) on #10517. |
Oh. Haha. @spicyj so clever! |
@acdlite For now I just turned everything into |
They weren't necessary and made things more confusing.
edcf8f2
to
34a5f00
Compare
Did this in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of https://github.com/facebook/react/pulls.
This is probably broken in some ways (and definitely breaks Jest) but some test displays Hello World. Builds are a few KBs down.
Probably don't want to land this until we have a way to run tests against bundles. Still was fun try. I intend to keep this (relatively) up to date hoping I can land it within a few weeks once the infra is there.