Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Run tests on PHPUnit 9 and PHP 8#142

Merged
WyriHaximus merged 3 commits intofriends-of-reactphp:masterfrom
SimonFrings:phpunit
Sep 3, 2021
Merged

Run tests on PHPUnit 9 and PHP 8#142
WyriHaximus merged 3 commits intofriends-of-reactphp:masterfrom
SimonFrings:phpunit

Conversation

@SimonFrings
Copy link
Contributor

@SimonFrings SimonFrings commented Aug 30, 2021

PHPUnit 9.3 released a new schema for the phpunit.xml configuration file. I had to migrate the file to the new format in order to avoid the warning. PHPUnit Versions older than 9.3 have to use the phpunit.xml.legacy configuration file, because the new format is unknown for them.

For further details concerning this pull request look into graphp/graphviz#46.
This pull request builds on top of #132.

It's also possible to run this code with PHP 8 🎉

$ docker run -it --rm -v `pwd`:/data --net=host --workdir=/data php:8.0.0 php vendor/bin/phpunit
PHPUnit 9.5.8 by Sebastian Bergmann and contributors.

...............................................................  63 / 201 ( 31%)
............................................................... 126 / 201 ( 62%)
....................................I.......................... 189 / 201 ( 94%)
............                                                    201 / 201 (100%)

Time: 00:00.480, Memory: 42.43 MB

OK, but incomplete, skipped, or risky tests!
Tests: 201, Assertions: 527, Incomplete: 1.

@clue clue added this to the v0.5.6 milestone Aug 30, 2021
Copy link
Contributor

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue requested a review from WyriHaximus September 2, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants