Update setup.py to load requirements from file and fix example in example.py #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for working on that! And so sorry for getting back to you so late. The recent events just knocked me down for a week and made me unable to work at all. Anyway, your changes look good. Give me a second to verify them on my machine, and then I'll merge the repo and bump the version. |
fspv
reviewed
Mar 5, 2022
|
Added one comment and tested both build and modified example.py. Everything LGTM as long as the comment is addressed. |
Co-authored-by: Pavel Safronov <pv.safronov@gmail.com>
|
Ah, that's must be some kind of a bad habit coz python isn't my main language :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and thanks for a great project!
I'm currently using this tool at my script to automatically get problem-related info to my local repo, create a code template for a solution, and automatically update a table with solved problems in README.md.
With this PR I've tried to fix two open issues