Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark values as optional in JSDoc #179

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Mark values as optional in JSDoc #179

merged 2 commits into from
Aug 22, 2018

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Aug 17, 2018

Prevents VS Code from getting angry at me 😄

screen shot 2018-08-17 at 15 43 57

@LinusU
Copy link
Contributor Author

LinusU commented Aug 17, 2018

Fixed the return value that was also erroneously marked as String

(another small nit that maybe we should fix, String should probably be string in all places in this code base. String refers to the class that wraps a primitive string in JavaScript. You cannot pass around those instances since they are always stripped by the runtime, and wrapped whenever you try to access a property on a string)

@jrf0110
Copy link
Member

jrf0110 commented Aug 22, 2018

Hey, sorry for the late merge. I've been on vacation. Just getting back to this.

@jrf0110 jrf0110 merged commit dec5fbe into goodybag:master Aug 22, 2018
@LinusU LinusU deleted the patch-1 branch August 27, 2018 12:00
@LinusU
Copy link
Contributor Author

LinusU commented Aug 27, 2018

No stress, thanks for merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinusU @jrf0110