Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

pubsub: use unary calls to send acks/modacks#3123

Merged
pongad merged 1 commit intogoogleapis:masterfrom
pongad:pubsub-send
Apr 4, 2018
Merged

pubsub: use unary calls to send acks/modacks#3123
pongad merged 1 commit intogoogleapis:masterfrom
pongad:pubsub-send

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented Apr 4, 2018

Previously we send ack/modack requests on the StreamingPull streams.
However, if pull responses are buffered, gRPC cannot promptly tell us
that the stream is broken, so we'll keep sending requests on the dead
stream.

This commit implements a temporary solution. We send requests by unary
RPCs instead and only use streaming for receiving messages.

Load test shows no regression. However, modacks seem to take longer to
take effect. The timeout for nack test had to be increased.

cc @mdietz94

Previously we send ack/modack requests on the StreamingPull streams.
However, if pull responses are buffered, gRPC cannot promptly tell us
that the stream is broken, so we'll keep sending requests on the dead
stream.

This commit implements a temporary solution. We send requests by unary
RPCs instead and only use streaming for receiving messages.

Load test shows no regression. However, modacks seem to take longer to
take effect. The timeout for nack test had to be increased.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 4, 2018
@mdietz94
Copy link

mdietz94 commented Apr 4, 2018

This LGTM. It is expected this would add additional latency to ack/mod ack operations, so all buffer amounts should be increased accordingly, but this looks good.

@pongad pongad merged commit d458207 into googleapis:master Apr 4, 2018
@pongad pongad deleted the pubsub-send branch April 4, 2018 20:38
@j256
Copy link

j256 commented May 30, 2018

For the record, this fix may also have the side effect of properly ack-ing messages when the subscriber is shutdown with acks outstanding. I was tracking a problem where acks were getting lost and it goes away in 0.43 which includes this PR. Thanks!

@j256
Copy link

j256 commented May 30, 2018

This also might actually be the change that fixed #3065.

@pongad
Copy link
Contributor Author

pongad commented May 30, 2018

Thank you for tracking this down. This seems to be a better change than expected... 😆

chingor13 pushed a commit that referenced this pull request Feb 20, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit that referenced this pull request Mar 9, 2026
… to v2.37.1 (#3123)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.37.0` -> `2.37.1` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.cloud:google-cloud-bigquery/2.37.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.cloud:google-cloud-bigquery/2.37.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.cloud:google-cloud-bigquery/2.37.0/2.37.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.cloud:google-cloud-bigquery/2.37.0/2.37.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-bigquery (com.google.cloud:google-cloud-bigquery)</summary>

### [`v2.37.1`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#2371-2024-02-06)

[Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.37.0...v2.37.1)

##### Features

-   Add queryId to TableResult ([#&#8203;3106](https://togithub.com/googleapis/java-bigquery/issues/3106)) ([2156f02](https://togithub.com/googleapis/java-bigquery/commit/2156f023b4ab95bc7ec669545b5709317555fdac))
-   Update universe domain exception error code/message ([#&#8203;3113](https://togithub.com/googleapis/java-bigquery/issues/3113)) ([5a82c85](https://togithub.com/googleapis/java-bigquery/commit/5a82c854b6549c82c905eba4905378b59cc88af4))

##### Dependencies

-   Update actions/upload-artifact action to v4.3.1 ([#&#8203;3121](https://togithub.com/googleapis/java-bigquery/issues/3121)) ([3abdc70](https://togithub.com/googleapis/java-bigquery/commit/3abdc70890c3f5c396055d7d34fc4fe18aef7371))
-   Update dependency com.google.apis:google-api-services-bigquery to v2-rev20240124-2.0.0 ([#&#8203;3104](https://togithub.com/googleapis/java-bigquery/issues/3104)) ([6eff68e](https://togithub.com/googleapis/java-bigquery/commit/6eff68eb8c55162ca1cd2e915f3f60a87f584b35))
-   Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.24.0 ([#&#8203;3109](https://togithub.com/googleapis/java-bigquery/issues/3109)) ([5ad778c](https://togithub.com/googleapis/java-bigquery/commit/5ad778c18130c33e7532d0bd3193053518ca047a))
-   Update dependency org.graalvm.buildtools:junit-platform-native to v0.10.0 ([#&#8203;3110](https://togithub.com/googleapis/java-bigquery/issues/3110)) ([3f8e8d1](https://togithub.com/googleapis/java-bigquery/commit/3f8e8d1f9477aed3a14bccf021d7ff982463022c))
-   Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.0 ([#&#8203;3111](https://togithub.com/googleapis/java-bigquery/issues/3111)) ([2858e96](https://togithub.com/googleapis/java-bigquery/commit/2858e96807190d995d9d682e056d90821da11b7a))
-   Update dependency org.junit.vintage:junit-vintage-engine to v5.10.2 ([#&#8203;3119](https://togithub.com/googleapis/java-bigquery/issues/3119)) ([4b4fdd8](https://togithub.com/googleapis/java-bigquery/commit/4b4fdd8ebc324d2bc48a9f78347247f4f6c2e424))
-   Update github/codeql-action action to v2.23.2 ([#&#8203;3102](https://togithub.com/googleapis/java-bigquery/issues/3102)) ([2cc545e](https://togithub.com/googleapis/java-bigquery/commit/2cc545ec1c0267fd9c33f3f1566f29d9a30f514e))
-   Update github/codeql-action action to v2.24.0 ([#&#8203;3114](https://togithub.com/googleapis/java-bigquery/issues/3114)) ([01f0405](https://togithub.com/googleapis/java-bigquery/commit/01f04059ab119da759536426938c1069906c8be4))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/java-bigquery).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants