Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Add support for Google Sheets external tables in BigQuery#3160

Merged
pongad merged 2 commits intogoogleapis:masterfrom
ladderlife:google-sheets-tables
Apr 17, 2018
Merged

Add support for Google Sheets external tables in BigQuery#3160
pongad merged 2 commits intogoogleapis:masterfrom
ladderlife:google-sheets-tables

Conversation

@mikekap
Copy link

@mikekap mikekap commented Apr 16, 2018

No description provided.

@mikekap mikekap requested a review from pongad as a code owner April 16, 2018 04:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2018
Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tswast can you also take a look?

GoogleSheetsOptions googleSheetsOptions = GOOGLE_SHEETS_OPTIONS.toBuilder()
.setSkipLeadingRows(123)
.build();
assertEquals(123, (long) googleSheetsOptions.getSkipLeadingRows());

This comment was marked as spam.

Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM but @tswast should sign off

Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pongad pongad merged commit 239c456 into googleapis:master Apr 17, 2018
suztomo pushed a commit that referenced this pull request Mar 9, 2026
… to v1.42.0 (#3160)

* deps: update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.42.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants