Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Add InsertAllRequest, InsertAllResponse and model classes for table data#443

Merged
aozarov merged 5 commits intogoogleapis:bigqueryfrom
mziccard:bigquery
Dec 11, 2015
Merged

Add InsertAllRequest, InsertAllResponse and model classes for table data#443
aozarov merged 5 commits intogoogleapis:bigqueryfrom
mziccard:bigquery

Conversation

@mziccard
Copy link
Contributor

@mziccard mziccard commented Dec 9, 2015

This PR will probably require some discussion :) I am eager to receive any feedback.
It adds:

Remarks:

  • We discussed with @aozarov about adding more information to FieldValue.Kind as REPEATED_OF_PRIMITIVE and REPEATED_OF_RECORD but I realized that an empty repeated field is returned as an empty array and there's no way to say whether it is of primitive or record type.

@mziccard mziccard added the api: bigquery Issues related to the BigQuery API. label Dec 9, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2015

This comment was marked as spam.

@mziccard
Copy link
Contributor Author

Thanks @ajkannan for the pass. I fixed the comments in place.

@mziccard
Copy link
Contributor Author

Should we make all value getters in FieldValue throw the same exception? Right now they either throw ClassCastException, IllegalStateException, NumberFormatException or NullPointerException depending on the type of conversion being asked. What do you think?

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants