Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Adding Bigtable factories and shell classes.#1229

Merged
dhermes merged 1 commit intogoogleapis:masterfrom
dhermes:bigtable-add-factories-and-shell-classes
Nov 19, 2015
Merged

Adding Bigtable factories and shell classes.#1229
dhermes merged 1 commit intogoogleapis:masterfrom
dhermes:bigtable-add-factories-and-shell-classes

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Nov 19, 2015

The Cluster, Table, Row and ColumnFamily classes (and modules) are introduced, but without any functionality except for other nested factories.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Nov 19, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2015

This comment was marked as spam.

This comment was marked as spam.

The Cluster, Table, Row and ColumnFamily classes (and
modules) are introduced, but without any functionality
except for other nested factories.
@dhermes dhermes force-pushed the bigtable-add-factories-and-shell-classes branch from a7172ad to 2547f84 Compare November 19, 2015 20:39
@dhermes
Copy link
Contributor Author

dhermes commented Nov 19, 2015

@tseaver I moved it into gcloud._helpers. Anything else blocking this PR?

@tseaver
Copy link
Contributor

tseaver commented Nov 19, 2015

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Nov 19, 2015

Coveralls having load problems. Merging before it passes.

dhermes added a commit that referenced this pull request Nov 19, 2015
…l-classes

Adding Bigtable factories and shell classes.
@dhermes dhermes merged commit 0773f5c into googleapis:master Nov 19, 2015
@dhermes dhermes deleted the bigtable-add-factories-and-shell-classes branch November 19, 2015 20:58
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Mar 9, 2026
* feat: add support for soft delete

* add restore, get object, list_objects, unit tests

* integration test

* update restore_blob

* SoftDeletePolicy data class

* update docstrings; address comments
parthea pushed a commit that referenced this pull request Mar 9, 2026
…emetry traces (#1229)

* all: implement custom tracer_provider injection

An important feature for observability is to allow the injection
of a custom tracer_provider instead of always using the global
tracer_provider by sending in

    observability_options=dict(
        tracer_provider=tracer_provider,
        enable_extended_tracing=True,
    )

* Address review feedback by attaching observability_options to Client only

* Attach observability_options directly before trace_call

* More reverts for formatting

* Plumb observability_options into _restart_on_unavailable

* completely decouple observability_options from session

* apply SPANNER_ENABLE_EXTENDED_TRACING but in inverse due to compatibility

* Document SPANNER_ENABLE_EXTENDED_TRACING in environment

* Revert a vestige of mock

* tests: add unit test for propagating TracerProvider

* Add preliminary end-to-end test to check for injection of observability_options

* Document default enable_extended_tracing value

* Carve out observability_options test

* Ensure that observability_options test sets up and deletes database

* Ensure instance.create() is invoked in system tests

* Use getattr for mock _Client

* Update with code review suggestions

* Deal with mock.Mock false positives failing tests

* Address review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants