Properly handling entity meanings in datastore.#1241
Merged
dhermes merged 1 commit intogoogleapis:masterfrom Dec 21, 2015
Merged
Properly handling entity meanings in datastore.#1241dhermes merged 1 commit intogoogleapis:masterfrom
dhermes merged 1 commit intogoogleapis:masterfrom
Conversation
Contributor
Author
|
@tseaver I think this spells the end of inheriting from |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@tseaver Bump |
aa7e011 to
20c1aed
Compare
Contributor
Author
|
@tseaver It is now merge-able |
gcloud/datastore/helpers.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
To do this, added entity_to_protobuf method that could be used recursively. Also solves googleapis#1206 since recursively serializing nested entities to protobuf was being done incorrectly. Fixes googleapis#1065. Fixes googleapis#1206.
20c1aed to
5873266
Compare
Contributor
Author
|
@tseaver PTAL, I went with the simpler version of |
Contributor
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Dec 21, 2015
Properly handling entity meanings in datastore.
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
…/python-docs-samples#1241) Protobuf handles the base64 encoding for you, and so the content was being base64 encoded twice.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
* fix: don't retry if error or error_description is not string * chore: fix flaky sample test * chore: update sys test cred
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes #1239
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209 <details><summary>google-cloud-bigtable: 2.35.0</summary> ## [2.35.0](googleapis/python-bigtable@v2.34.0...v2.35.0) (2025-12-16) ### Features * add basic interceptor to client (#1206) ([6561cfac](googleapis/python-bigtable@6561cfac)) * Add encodings for STRUCT and the Timestamp type ([72dfdc44](googleapis/python-bigtable@72dfdc44)) * add PeerInfo proto in Bigtable API ([72dfdc44](googleapis/python-bigtable@72dfdc44)) * Add Type API updates needed to support structured keys in materialized views ([72dfdc44](googleapis/python-bigtable@72dfdc44)) * support mTLS certificates when available (#1249) ([ca20219c](googleapis/python-bigtable@ca20219c)) ### Bug Fixes * re-export AddToCell for consistency (#1241) ([2a5baf11](googleapis/python-bigtable@2a5baf11)) * async client uses fixed grace period (#1236) ([544db1cd](googleapis/python-bigtable@544db1cd)) * Deprecate credentials_file argument ([72dfdc44](googleapis/python-bigtable@72dfdc44)) * Add ReadRows/SampleRowKeys bindings for materialized views ([72dfdc44](googleapis/python-bigtable@72dfdc44)) * retry cancelled errors (#1235) ([e3fd5d86](googleapis/python-bigtable@e3fd5d86)) </details>
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* observability: add updated span events + traace more methods This change carves out parts of PR #1241 in smaller pieces to ease with smaller reviews. This change adds more span events, updates important spans to make them more distinct like changing: "CloudSpanner.ReadWriteTransaction" to more direct and more pointed spans like: * CloudSpanner.Transaction.execute_streaming_sql Also added important spans: * CloudSpanner.Database.run_in_transaction * CloudSpanner.Session.run_in_transaction * all: update review comments + show type for BeginTransaction + remove prints * Remove requested span event "Using Transaction" * Move attempts into try block * Transform Session.run_in_transaction retry exceptions into events * More comprehensive test for events and attributes for pool.get * Add test guards against Python3.7 for which OpenTelemetry is unavailable + address test feedback * Remove span event per mutation in favour of future TODO Referencing issue #1269, this update removes adding a span event per mutation, in favour of a future TODO. * Sort system-test.test_transaction_abort_then_retry_spans spans by create time * Delint tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do this, added
entity_to_protobufmethod that could be used recursively. Also solves #1206 since recursively serializing nested entities to protobuf was being done incorrectly.Fixes #1065. Fixes #1206.