Merged
Conversation
Contributor
Author
|
@jgeewax PTAL as well |
docs/bigtable-row.rst
Outdated
| Bigtable Row | ||
| ============ | ||
|
|
||
| A |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Does it make sense to stuff the autogen stuff under a |
Contributor
|
Finished a pass, please let me know when you're ready for another round. |
| >>> from gcloud import bigtable | ||
| >>> client = bigtable.Client() | ||
|
|
||
| or pass in ``credentials`` and ``project`` explicitly |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@jonparrott Just pushed a new commit PTAL. I did a full pass to make sure things still made sense (since the API has changed over time) and found a few changes to make here and there (many are stylistic). |
7735980 to
3ac5294
Compare
Contributor
|
This LGTM once @jgeewax's comments are addressed. (Also don't forget to squash) |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs serving (for now at least, as of 12:45pm Pacific on Feb. 26): https://blog.bossylobster.com/gcloud-python/latest/bigtable-usage.html