Fix #324: Move ACL back-end manipulations from bucket / key to acl objects by tseaver · Pull Request #326 · googleapis/google-cloud-python

tseaver · 2014-10-31T23:10:50Z

tseaver · 2014-10-31T23:12:02Z

Presumes #318 is landed first.

coveralls · 2014-10-31T23:14:52Z

Coverage remained the same when pulling 99b78b2 on tseaver:324-move_acl_manip_from_bucket_key_to_acl into 8e12e10 on GoogleCloudPlatform:master.

dhermes · 2014-10-31T23:18:55Z

I'll hold off review until #318 lands. Please remind me if I forget.

- Refactor lazy-handling of 'acl' and 'default_object_acl' using properties. - Fetch 'ac' and 'defaultObjectAcl' via GET to specific endpoints. - Continue to update 'acl' and 'defaultObjectAcl' via PATCH to the object's resource (we can't do incremental updates to ACEs). Fixes #163.

- Refactor lazy-handling of 'acl' using a property. - Fetch 'acl' via GET to a specific endpoint. - Continue to update 'acl' via PATCH to the object's resource (we can't do incremental updates to ACEs). Fixes #151.

Borked by dropping the 'projection' qs param to PATCH. Docs spell a default, but then note that overriding it w/ 'full' is required (and we need 'full' anyway, because we expect to read the resulting ACL back).

Fixes #324.

tseaver · 2014-11-01T02:03:34Z

@dhermes Rebased after landing #318.

coveralls · 2014-11-01T02:05:41Z

Coverage remained the same when pulling 9cfe627 on tseaver:324-move_acl_manip_from_bucket_key_to_acl into 632e126 on GoogleCloudPlatform:master.

gcloud/storage/acl.py

@dhermes

Drop unneeded comment. Feedback from @dhermes.

coveralls · 2014-11-03T18:37:09Z

Coverage remained the same when pulling bb9a3a8 on tseaver:324-move_acl_manip_from_bucket_key_to_acl into 632e126 on GoogleCloudPlatform:master.

tseaver · 2014-11-03T19:41:05Z

@dhermes PTAL.

dhermes · 2014-11-03T21:48:13Z

LGTM

I really wish GitHub would let us keep track of what we had already reviewed and then pick and choose which commits the left-hand and right-hand diffs are in the side-by-side view.

…ey_to_acl Fix #324: Move ACL back-end manipulations from bucket / key to acl objects

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472772457 Source-Link: googleapis/googleapis@855b74d Source-Link: googleapis/googleapis-gen@b64b1e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9

* ci(python): run lint / unit tests / docs as GH actions Source-Link: googleapis/synthtool@57be0cd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6 * add a commit to activate gh actions * workaround bug in templates Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

…p/templates/python_library/.kokoro (#326) Source-Link: https://togithub.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

…[autoapprove] (#326) Source-Link: googleapis/synthtool@1f37ce7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

E.g. import.proto turns into import_.py, not import.py This allows the module to be imported via the normal import mechanisms.

Source-Link: googleapis/synthtool@3551acd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:230f7fe8a0d2ed81a519cfc15c6bb11c5b46b9fb449b8b1219b3771bcb520ad2 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: update .repo-metadata.json * revert * remove api_shortname

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@aa69fb7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cf Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. Co-authored-by: Christopher Wilcox <crwilcox@google.com>

…#324) * Remove EXPERIMENTAL tag for ordering keys in publisher/client.py * fix(sample): mark test flaky (#326) * fix(sample): retry InternalServerError (#329) fixes #321 Co-authored-by: Tianzi Cai <tianzi@google.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com>

Source-Link: googleapis/synthtool@f15cc72 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd

…326) Explicit 'encoding' overrides the fallback. Use the 'charset' param of 'content_type', rather than 'content_encoding', which isn't going to be a Unicode -> bytes encoding. Closes #319. Also, rewrap long param descriptions for in-source readability.

Bumps [grpcio](https://togithub.com/grpc/grpc) from 1.50.0 to 1.53.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://togithub.com/grpc/grpc/releases">grpcio's releases</a>.</em></p> <blockquote> <h2>Release v1.53.0</h2> <p>This is release 1.53.0 (<a href="https://togithub.com/grpc/grpc/blob/master/doc/g_stands_for.md">glockenspiel</a>) of gRPC Core.</p> <p>For gRPC documentation, see <a href="https://grpc.io/">grpc.io</a>. For previous releases, see <a href="https://togithub.com/grpc/grpc/releases">Releases</a>.</p> <p>This release contains refinements, improvements, and bug fixes, with highlights listed below.</p> <h2>Core</h2> <ul> <li>xDS: fix crash when removing the last endpoint from the last locality in weighted_target. (<a href="https://redirect.github.com/grpc/grpc/pull/32592">#32592</a>)</li> <li>filter stack: pass peer name up via recv_initial_metadata batch. (<a href="https://redirect.github.com/grpc/grpc/pull/31933">#31933</a>)</li> <li>[EventEngine] Add advice against blocking work in callbacks. (<a href="https://redirect.github.com/grpc/grpc/pull/32397">#32397</a>)</li> <li>[http2] Dont drop connections on metadata limit exceeded. (<a href="https://redirect.github.com/grpc/grpc/pull/32309">#32309</a>)</li> <li>xDS: reject aggregate cluster with empty cluster list. (<a href="https://redirect.github.com/grpc/grpc/pull/32238">#32238</a>)</li> <li>Fix Python epoll1 Fork Support. (<a href="https://redirect.github.com/grpc/grpc/pull/32196">#32196</a>)</li> <li>server: introduce ServerMetricRecorder API and move per-call reporting from a C++ interceptor to a C-core filter. (<a href="https://redirect.github.com/grpc/grpc/pull/32106">#32106</a>)</li> <li>[EventEngine] Add invalid handle types to the public API. (<a href="https://redirect.github.com/grpc/grpc/pull/32202">#32202</a>)</li> <li>[EventEngine] Refactoring the EventEngine Test Suite: Part 1. (<a href="https://redirect.github.com/grpc/grpc/pull/32127">#32127</a>)</li> <li>xDS: fix WeightedClusters total weight handling. (<a href="https://redirect.github.com/grpc/grpc/pull/32134">#32134</a>)</li> </ul> <h2>C++</h2> <ul> <li>Update minimum MSVC version to 2019. (<a href="https://redirect.github.com/grpc/grpc/pull/32615">#32615</a>)</li> <li>Use CMake variables for paths in pkg-config files. (<a href="https://redirect.github.com/grpc/grpc/pull/31671">#31671</a>)</li> </ul> <h2>C#</h2> <ul> <li>Grpc.Tools: Use x86 protoc binaries on arm64 Windows. (<a href="https://redirect.github.com/grpc/grpc/pull/32017">#32017</a>)</li> </ul> <h2>Python</h2> <ul> <li>Support python 3.11 on aarch64. (<a href="https://redirect.github.com/grpc/grpc/pull/32270">#32270</a>)</li> <li>Include .pyi file. (<a href="https://redirect.github.com/grpc/grpc/pull/32268">#32268</a>)</li> <li>De-experimentalize wait-for-ready. (<a href="https://redirect.github.com/grpc/grpc/pull/32143">#32143</a>)</li> <li>De-experimentalize compression. (<a href="https://redirect.github.com/grpc/grpc/pull/32138">#32138</a>)</li> </ul> <h2>Ruby</h2> <ul> <li>[ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6. (<a href="https://redirect.github.com/grpc/grpc/pull/32089">#32089</a>)</li> </ul> <h2>Release v1.53.0-pre2</h2> <p>This is a prerelease of gRPC Core 1.53.0 (glockenspiel).</p> <p>For gRPC documentation, see <a href="https://grpc.io/">grpc.io</a>. For previous releases, see <a href="https://togithub.com/grpc/grpc/releases">Releases</a>.</p>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://togithub.com/grpc/grpc/commit/358bfb581feeda5bf17dd3b96da1074d84a6ef8d"><code>358bfb5</code></a> Bump version to 1.53.0 (<a href="https://redirect.github.com/grpc/grpc/issues/32685">#32685</a>)</li> <li><a href="https://togithub.com/grpc/grpc/commit/6e1ebe76d87a2e9b643c08b3e234d374edcd9e92"><code>6e1ebe7</code></a> Backport: Ensure compatibility with the new custom kokoro win2019 image (<a href="https://redirect.github.com/grpc/grpc/issues/326">#326</a>...</li> <li><a href="https://togithub.com/grpc/grpc/commit/44a77f6e911b95e1bc2c909b348123b2da2c4375"><code>44a77f6</code></a> Backport 1.53: Update minimum MSVC version to 2019 (<a href="https://redirect.github.com/grpc/grpc/issues/32615">#32615</a>)</li> <li><a href="https://togithub.com/grpc/grpc/commit/c11153cb4ef01ca5f83304b2e28edd0182b3c0d0"><code>c11153c</code></a> backport to 1.53: xDS: fix crash when removing the last endpoint from the las...</li> <li><a href="https://togithub.com/grpc/grpc/commit/7c7712a6b08ebf1bdc18fc43dc871b47b3dffe97"><code>7c7712a</code></a> Bump version to 1.53.0-pre2. (<a href="https://redirect.github.com/grpc/grpc/issues/32545">#32545</a>)</li> <li><a href="https://togithub.com/grpc/grpc/commit/a4017dc45e342064722a36181ed14e6d7b469d29"><code>a4017dc</code></a> backport to 1.53: [promises] Make Poll<T> its own type, not a variant<> (<a href="https://redirect.github.com/grpc/grpc/issues/32540">#32540</a>)</li> <li><a href="https://togithub.com/grpc/grpc/commit/3f93c1667280e6f11a1eb35cccfb8c81c698bee5"><code>3f93c16</code></a> Fuzzer fix backport to v1.53 (<a href="https://redirect.github.com/grpc/grpc/issues/32511">#32511</a>)</li> <li><a href="https://togithub.com/grpc/grpc/commit/5b244b25c2b87a85781ceeecd34ce0f8e8e7e840"><code>5b244b2</code></a> Bump release version to 1.53.0-pre1 (<a href="https://redirect.github.com/grpc/grpc/issues/32428">#32428</a>)</li> <li><a href="https://togithub.com/grpc/grpc/commit/6589340efc39b87c94897d221eaf949213cdac87"><code>6589340</code></a> Bump core version 202302161703 (<a href="https://redirect.github.com/grpc/grpc/issues/32416">#32416</a>)</li> <li><a href="https://togithub.com/grpc/grpc/commit/d49e1513063e6624e08eb6f59049596178a28783"><code>d49e151</code></a> [backoff] Add random early detection classifier (<a href="https://redirect.github.com/grpc/grpc/issues/32354">#32354</a>)</li> <li>Additional commits viewable in <a href="https://togithub.com/grpc/grpc/compare/v1.50.0...v1.53.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=grpcio&package-manager=pip&previous-version=1.50.0&new-version=1.53.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://togithub.com/googleapis/sphinx-docfx-yaml/network/alerts). </details>

tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: storage Issues related to the Cloud Storage API. labels Oct 31, 2014

tseaver added 4 commits October 31, 2014 21:58

Use ACL-specific endpoints where feasible for keys.

65d9962

- Refactor lazy-handling of 'acl' using a property. - Fetch 'acl' via GET to a specific endpoint. - Continue to update 'acl' via PATCH to the object's resource (we can't do incremental updates to ACEs). Fixes #151.

Fix save/clear ACL operations.

417333c

Borked by dropping the 'projection' qs param to PATCH. Docs spell a default, but then note that overriding it w/ 'full' is required (and we need 'full' anyway, because we expect to read the resulting ACL back).

Move APIs for reload/save/clear ACLs onto ACL objects themselves.

9cfe627

Fixes #324.

tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 1, 2014

dhermes reviewed Nov 1, 2014
View reviewed changes

gcloud/storage/acl.py Outdated

This comment was marked as spam.

Sign in to view

tseaver added 3 commits November 3, 2014 13:23

Rename 'dirty'->'save_to_backend'.

d7a1beb

Drop unneeded comment. Feedback from @dhermes.

Use 'add_entity' directly when populating from scratch.

5689c02

Improve class attr name: '_SUBKEY'->'_URL_PATH_ELEM'.

bb9a3a8

tseaver added a commit that referenced this pull request Nov 3, 2014

Merge pull request #326 from tseaver/324-move_acl_manip_from_bucket_k…

963d0dd

…ey_to_acl Fix #324: Move ACL back-end manipulations from bucket / key to acl objects

tseaver merged commit 963d0dd into googleapis:master Nov 3, 2014

tseaver deleted the 324-move_acl_manip_from_bucket_key_to_acl branch November 6, 2014 22:43

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

logging resumable upload expiration datetime for debug googleapis#326

38700f6

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-auth to v2.16.0 (#326)

3d74264

parthea added a commit that referenced this pull request Sep 22, 2023

chore(main): release 3.6.1 (#326)

0f8ef07

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v7.2.2 (#326)

f2b1d95

parthea added a commit that referenced this pull request Sep 22, 2023

fix(deps): require protobuf <4.0.0dev (#326)

a7dce25

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-kms to v2.12.1 (#326)

219332f

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-storage to v2.2.0 (#326)

cc732af

parthea added a commit that referenced this pull request Oct 21, 2023

chore: make samples 3.6 check optional (#326)

fc95b37

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea added a commit that referenced this pull request Jan 10, 2025

chore: remove pb2 file generation during post processing step (#326)

729f598

parthea added a commit that referenced this pull request Nov 22, 2025

fix(deps): add packaging requirement (#326)

835ec33

parthea pushed a commit that referenced this pull request Nov 24, 2025

Disambiguate Python-keyword-named modules (#326)

6eb7e15

E.g. import.proto turns into import_.py, not import.py This allows the module to be imported via the normal import mechanisms.

parthea added a commit that referenced this pull request Nov 24, 2025

chore: update release_level in repo-metadata.json (#326)

948d129

* chore: update .repo-metadata.json * revert * remove api_shortname

parthea added a commit that referenced this pull request Nov 24, 2025

fix: Declare support for Python 3.13 (#326)

68db541

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(main): release 2.7.0 (#326)

fb00386

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Mar 2, 2026

fix(sample): mark test flaky (#326)

eb33c85

parthea pushed a commit that referenced this pull request Mar 9, 2026

fix: disables sequence support (#326)

a046afa

parthea pushed a commit that referenced this pull request Mar 9, 2026

chore(deps): update dependency google-cloud-testutils to v0.2.0 (#326)

e4bc4e4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #324: Move ACL back-end manipulations from bucket / key to acl objects#326

Fix #324: Move ACL back-end manipulations from bucket / key to acl objects#326
tseaver merged 7 commits intogoogleapis:masterfrom
tseaver:324-move_acl_manip_from_bucket_key_to_acl

tseaver commented Oct 31, 2014

Uh oh!

tseaver commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

dhermes commented Oct 31, 2014

Uh oh!

tseaver commented Nov 1, 2014

Uh oh!

coveralls commented Nov 1, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 3, 2014

Uh oh!

tseaver commented Nov 3, 2014

Uh oh!

dhermes commented Nov 3, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tseaver commented Oct 31, 2014

Uh oh!

tseaver commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

dhermes commented Oct 31, 2014

Uh oh!

tseaver commented Nov 1, 2014

Uh oh!

coveralls commented Nov 1, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 3, 2014

Uh oh!

tseaver commented Nov 3, 2014

Uh oh!

dhermes commented Nov 3, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants