Conversation
|
@crwilcox We have broken monitoring system tests from the merge of #5594. |
|
@tseaver interesting. I will look into this first thing tomorrow. I thought I ran the system tests but perhaps I did it before being finished. Thanks! |
|
@crwilcox One think you might not know: in CI, we don't run system tests for PRs created against branches in forked repos, because of worries about exposing secrets. So, for any test which touches system tests, it is better to push the branch to this repo, rather than the fork, in order to let CI help catch things before merging. |
|
#5608 fixes the breakage. I don't know whether this PR should be closed, and a new one generated, or whether just rebasing would work fine (the changelog might need updating?) |
|
Superseded by #5616. |
This pull request was generated using releasetool.