Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

BigQuery: allow setting None as partition expiration #6823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 1 commit into from
Dec 3, 2018
Merged

BigQuery: allow setting None as partition expiration #6823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bigquery/google/cloud/bigquery/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1335,7 +1335,10 @@ def expiration_ms(self):

@expiration_ms.setter
def expiration_ms(self, value):
self._properties["expirationMs"] = str(value)
if value is not None:
# Allow explicitly setting the expiration to None.
value = str(value)
self._properties["expirationMs"] = value

@property
def require_partition_filter(self):
Expand Down
5 changes: 5 additions & 0 deletions bigquery/tests/unit/test_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1683,3 +1683,8 @@ def test___repr___explicit(self):
"type=DAY)"
)
self.assertEqual(repr(time_partitioning), expected)

def test_set_expiration_w_none(self):
time_partitioning = self._make_one()
time_partitioning.expiration_ms = None
assert time_partitioning._properties["expirationMs"] is None