Adding missing properties from LoadJobConfig to LoadJob library#7710
Merged
tswast merged 4 commits intogoogleapis:masterfrom Apr 15, 2019
Merged
Adding missing properties from LoadJobConfig to LoadJob library#7710tswast merged 4 commits intogoogleapis:masterfrom
tswast merged 4 commits intogoogleapis:masterfrom
Conversation
tswast
reviewed
Apr 15, 2019
Contributor
tswast
left a comment
There was a problem hiding this comment.
LGTM once there is a test for non-None description and friendly name.
bigquery/tests/unit/test_job.py
Outdated
| else: | ||
| self.assertIsNone(job.destination_encryption_configuration) | ||
|
|
||
| if "destinationTableDescription" in config: |
Contributor
There was a problem hiding this comment.
Sorry, _verifyResourceProperties isn't a very good example to follow. I prefer explicitly setting the values you are looking for in the test itself.
Please remove this code and add check for string values for destination_table_description and destination_table_friendly_name to test_ctor_w_config.
tswast
approved these changes
Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7482
@tswast @engelke