Preserve order in to_dataframe with BQ Storage from queries containing ORDER BY#7793
Merged
tswast merged 3 commits intogoogleapis:masterfrom Apr 30, 2019
Merged
Conversation
shollyman
approved these changes
Apr 26, 2019
| if query is None: | ||
| return False | ||
|
|
||
| return re.search(r"ORDER\s+BY", query, re.IGNORECASE) is not None |
Contributor
There was a problem hiding this comment.
Should we have a comment indicating we know there's a class of false positives (ordered window functions)?
tseaver
suggested changes
Apr 29, 2019
| if query is None: | ||
| return False | ||
|
|
||
| return re.search(r"ORDER\s+BY", query, re.IGNORECASE) is not None |
Contributor
There was a problem hiding this comment.
Please compile the pattern as a module-scope global, and use "raw" strings e.g.:
_CONTAINS_ORDER_BY = re.compile(r"ORDER\s+BY", re.IGNORECASE)
...
def _contains_order_by(query):
"""Do we need to preserve the order of the query results?"""
return query and _CONTAINS_ORDER_BY.search(query)…ng ORDER BY This fixes an issue where due to reading from multiple stream in parallel, the order of rows is not preserved. Normally this isn't an issue, but it is when the rows are query results from an ORDER BY query.
3b0c7ae to
babdd66
Compare
tseaver
approved these changes
Apr 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where due to reading from multiple stream in
parallel, the order of rows is not preserved. Normally this isn't an
issue, but it is when the rows are query results from an
ORDER BYquery.Note: The detection of
ORDER BYis not perfect. It will have false positives (such asORDER BYin a string or sub-query), but hopefully no false negatives. Since a false positive only means we read from a single stream, behavior is correct but perhaps slower than expected.Closes #7759