Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Logging: Pass 'stream' argument to super in 'ContainerEngineHandler.__init__'.#9166

Merged
tseaver merged 1 commit intogoogleapis:masterfrom
aviau:patch-1
Sep 4, 2019
Merged

Logging: Pass 'stream' argument to super in 'ContainerEngineHandler.__init__'.#9166
tseaver merged 1 commit intogoogleapis:masterfrom
aviau:patch-1

Conversation

@aviau
Copy link
Contributor

@aviau aviau commented Sep 3, 2019

It looks like this was broken here: aee5cec#diff-c49b1ce108fd52ae2640bc8afc4415d7R40

@aviau aviau requested a review from busunkim96 as a code owner September 3, 2019 21:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 3, 2019
@aviau
Copy link
Contributor Author

aviau commented Sep 3, 2019

\cc @tseaver

@tseaver tseaver changed the title ContainerEngineHandler: don't swallow stream Logging: Pass 'stream' argument to super in 'ContainerEngineHandler.__init__'. Sep 3, 2019
@tseaver tseaver added api: logging Issues related to the Cloud Logging API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 3, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2019
@tseaver tseaver merged commit 0b663e4 into googleapis:master Sep 4, 2019
@tseaver
Copy link
Contributor

tseaver commented Sep 4, 2019

@aviau Thank you for the patch!

emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 11, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants