Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

chore: add 'maxResults' field to detectWebEntity#799

Merged
eaball35 merged 11 commits intogoogleapis:mainfrom
aribray:aribray--flaky
Feb 3, 2022
Merged

chore: add 'maxResults' field to detectWebEntity#799
eaball35 merged 11 commits intogoogleapis:mainfrom
aribray:aribray--flaky

Conversation

@aribray
Copy link
Contributor

@aribray aribray commented Feb 1, 2022

Change-Id: I51d6db25579557b675ccb200af318155a671c998

The detectWebEntities... methods return 10 results by default, and sometimes the web entity being tested against didn't make the cut. I raised maxResults to 15.

Fixes #734 ☕️

@aribray
chore: add 'maxResults' field to detectWebEntity
111a564 
Change-Id: I51d6db25579557b675ccb200af318155a671c998
@aribray aribray requested a review from a team February 1, 2022 19:50
@product-auto-label product-auto-label bot added the api: vision Issues related to the googleapis/java-vision API. label Feb 1, 2022
@aribray aribray added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 1, 2022
aribray and others added 6 commits February 1, 2022 12:27
@aribray
fix linting
1f2f880 
Change-Id: Icf702c6ca3817820c0fb7e831e6eb373473218ab
@gcf-owl-bot
🦉 Updates from OwlBot
4b5e7aa 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'aribray--flaky' of https://github.com/aribray/java-vision…
3cc074f 
… into aribray--flaky
@renovate-bot @aribray
build(deps): update dependency org.codehaus.mojo:build-helper-maven-p…
8c31a62 
…lugin to v3.3.0 (googleapis#778)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.codehaus.mojo:build-helper-maven-plugin](http://www.mojohaus.org/build-helper-maven-plugin/) ([source](https://togithub.com/mojohaus/build-helper-maven-plugin)) | `3.2.0` -> `3.3.0` | [![age](https://badges.renovateapi.com/packages/maven/org.codehaus.mojo:build-helper-maven-plugin/3.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.codehaus.mojo:build-helper-maven-plugin/3.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.codehaus.mojo:build-helper-maven-plugin/3.3.0/compatibility-slim/3.2.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.codehaus.mojo:build-helper-maven-plugin/3.3.0/confidence-slim/3.2.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-vision).
@renovate-bot @aribray
deps: update dependency com.google.cloud:google-cloud-core to v2.4.0 (g…
3a10482 
…oogleapis#797)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.3.5` -> `2.4.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.4.0/compatibility-slim/2.3.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.4.0/confidence-slim/2.3.5)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.4.0`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;240-httpsgithubcomgoogleapisjava-corecomparev235v240-2022-01-28)

[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.3.5...v2.4.0)

##### Features

-   **java:** Add native-image support classes to java-core module  ([#&#8203;637](https://togithub.com/googleapis/java-core/issues/637)) ([154bc18](https://togithub.com/googleapis/java-core/commit/154bc18ba86328d29665c502db1d35e265c92bbf))

##### Bug Fixes

-   **java:** initialize LoggerFactory at build time ([#&#8203;685](https://togithub.com/googleapis/java-core/issues/685)) ([eb3aba2](https://togithub.com/googleapis/java-core/commit/eb3aba2455a0ab6ffec2c6beb3f3cbb4bcb6008d))

##### Dependencies

-   **java:** update actions/github-script action to v5 ([#&#8203;1339](https://togithub.com/googleapis/java-core/issues/1339)) ([#&#8203;689](https://togithub.com/googleapis/java-core/issues/689)) ([eb462c7](https://togithub.com/googleapis/java-core/commit/eb462c7b1a005ce37d1be58900a244f6b807e5d5))
-   update dependency com.google.api-client:google-api-client-bom to v1.33.1 ([#&#8203;684](https://togithub.com/googleapis/java-core/issues/684)) ([9ff47e6](https://togithub.com/googleapis/java-core/commit/9ff47e68d0c435d7636d89b03369aabbdfe3663b))
-   update dependency com.google.api:api-common to v2.1.3 ([#&#8203;694](https://togithub.com/googleapis/java-core/issues/694)) ([684ae80](https://togithub.com/googleapis/java-core/commit/684ae805b8d25747830ce9266fd51a287c018cc9))
-   update dependency com.google.api:gax-bom to v2.11.0 ([#&#8203;677](https://togithub.com/googleapis/java-core/issues/677)) ([1a578bd](https://togithub.com/googleapis/java-core/commit/1a578bdee2fa229ffbdd8fdde3d66d7e29dedf98))
-   update dependency com.google.api.grpc:proto-google-common-protos to v2.7.2 ([#&#8203;695](https://togithub.com/googleapis/java-core/issues/695)) ([1085d2c](https://togithub.com/googleapis/java-core/commit/1085d2cb1d7e8391f981d1f4b97c7724b0107e94))
-   update dependency com.google.api.grpc:proto-google-iam-v1 to v1.2.1 ([#&#8203;667](https://togithub.com/googleapis/java-core/issues/667)) ([b57ec04](https://togithub.com/googleapis/java-core/commit/b57ec047234a1a044458980a8cf7de6a3156bf41))
-   update dependency com.google.auth:google-auth-library-bom to v1.4.0 ([#&#8203;681](https://togithub.com/googleapis/java-core/issues/681)) ([3273b1e](https://togithub.com/googleapis/java-core/commit/3273b1ed0b1db610790e7832a6c92797a341cc7d))
-   update dependency com.google.errorprone:error_prone_annotations to v2.11.0 ([#&#8203;687](https://togithub.com/googleapis/java-core/issues/687)) ([dc4d18d](https://togithub.com/googleapis/java-core/commit/dc4d18de86695fddbcb9d221cc53fdca3faf09f5))
-   update dependency com.google.http-client:google-http-client-bom to v1.41.1 ([#&#8203;683](https://togithub.com/googleapis/java-core/issues/683)) ([45cb753](https://togithub.com/googleapis/java-core/commit/45cb7535151cfcffa282b4c8d9cd56265cca2ece))
-   update dependency com.google.http-client:google-http-client-bom to v1.41.2 ([#&#8203;696](https://togithub.com/googleapis/java-core/issues/696)) ([f4875c0](https://togithub.com/googleapis/java-core/commit/f4875c0deecfea3728925e5ee0ef95ee90852301))
-   update dependency com.google.protobuf:protobuf-bom to v3.19.3 ([#&#8203;674](https://togithub.com/googleapis/java-core/issues/674)) ([c54f997](https://togithub.com/googleapis/java-core/commit/c54f9973b71c91c1fde0a1d128957cd022a27902))
-   update dependency io.grpc:grpc-bom to v1.43.2 ([#&#8203;665](https://togithub.com/googleapis/java-core/issues/665)) ([752ba6e](https://togithub.com/googleapis/java-core/commit/752ba6e384c382d0e39d8335640eaaea2beee9e1))
-   update dependency io.grpc:grpc-bom to v1.44.0 ([#&#8203;693](https://togithub.com/googleapis/java-core/issues/693)) ([ed85045](https://togithub.com/googleapis/java-core/commit/ed850455995fc5b5c2dae3595116721316f63698))
-   update dependency org.easymock:easymock to v4 ([#&#8203;668](https://togithub.com/googleapis/java-core/issues/668)) ([c36e976](https://togithub.com/googleapis/java-core/commit/c36e976c0379c1119dfe643dc3131f2e52130c5c))
-   update dependency org.graalvm.sdk:graal-sdk to v22 ([#&#8203;680](https://togithub.com/googleapis/java-core/issues/680)) ([0f535f8](https://togithub.com/googleapis/java-core/commit/0f535f869f7ce68192f821d0f3361634676dddf7))
-   update graalvm.version to v21.3.1 ([#&#8203;679](https://togithub.com/googleapis/java-core/issues/679)) ([dfb305a](https://togithub.com/googleapis/java-core/commit/dfb305acaf9d6db91727e42509fc6b043f07a5ce))
-   update graalvm.version to v22.0.0.2 ([#&#8203;691](https://togithub.com/googleapis/java-core/issues/691)) ([780b734](https://togithub.com/googleapis/java-core/commit/780b734bb4f26fab49065f303d102033b2c3a3d0))
-   update opencensus.version to v0.30.0 ([#&#8203;646](https://togithub.com/googleapis/java-core/issues/646)) ([c2caaa7](https://togithub.com/googleapis/java-core/commit/c2caaa7cb2c094318e611ba2c082a8a31fee21ea))
-   update opencensus.version to v0.31.0 ([#&#8203;692](https://togithub.com/googleapis/java-core/issues/692)) ([bdf7d4e](https://togithub.com/googleapis/java-core/commit/bdf7d4ec05c5314e5f2667287ed3e7cb83667c35))

##### [2.3.5](https://www.github.com/googleapis/java-core/compare/v2.3.4...v2.3.5) (2022-01-06)

##### Dependencies

-   update dependency com.google.api:api-common to v2.1.2 ([#&#8203;661](https://www.togithub.com/googleapis/java-core/issues/661)) ([0a136d8](https://www.github.com/googleapis/java-core/commit/0a136d8122f6c5042808cbfee9e58dc53e368da6))
-   update gax.version to v2.8.1 ([#&#8203;663](https://www.togithub.com/googleapis/java-core/issues/663)) ([7c09aa5](https://www.github.com/googleapis/java-core/commit/7c09aa5729408a395f1a8fae94744f9d33638b1a))

##### [2.3.4](https://www.github.com/googleapis/java-core/compare/v2.3.3...v2.3.4) (2022-01-06)

##### Bug Fixes

-   fixed compilation warnings from error prone ([e6e7040](https://www.github.com/googleapis/java-core/commit/e6e7040305b19ec9d5468f4cd44d7a29d0d5e470))
-   **java:** add -ntp flag to native image testing command ([#&#8203;1299](https://www.togithub.com/googleapis/java-core/issues/1299)) ([#&#8203;643](https://www.togithub.com/googleapis/java-core/issues/643)) ([0f4c1db](https://www.github.com/googleapis/java-core/commit/0f4c1dbbd89d82f5cc86c2b684d6645699b835b3))
-   **java:** run Maven in plain console-friendly mode ([#&#8203;1301](https://www.togithub.com/googleapis/java-core/issues/1301)) ([#&#8203;652](https://www.togithub.com/googleapis/java-core/issues/652)) ([ab2fa93](https://www.github.com/googleapis/java-core/commit/ab2fa93ba0434f593abb063afad44dc923bf462a))

##### Dependencies

-   update dependency com.google.api-client:google-api-client-bom to v1.33.0 ([#&#8203;658](https://www.togithub.com/googleapis/java-core/issues/658)) ([d417ebd](https://www.github.com/googleapis/java-core/commit/d417ebd7bedc9d4e983f32c87a8d61163502cf1d))
-   update dependency com.google.api:gax-bom to v2.8.0 ([#&#8203;659](https://www.togithub.com/googleapis/java-core/issues/659)) ([91717ab](https://www.github.com/googleapis/java-core/commit/91717ab9361a31976727b26d08837e8b3838bdb4))
-   update dependency com.google.api.grpc:proto-google-common-protos to v2.7.1 ([#&#8203;656](https://www.togithub.com/googleapis/java-core/issues/656)) ([ecfbdc1](https://www.github.com/googleapis/java-core/commit/ecfbdc181087d37d38f7911b9962953f5d246434))
-   update dependency com.google.api.grpc:proto-google-iam-v1 to v1.2.0 ([#&#8203;645](https://www.togithub.com/googleapis/java-core/issues/645)) ([3926b54](https://www.github.com/googleapis/java-core/commit/3926b5423893635dd709b8fc6037fb896396ff13))
-   update dependency com.google.http-client:google-http-client-bom to v1.41.0 ([#&#8203;657](https://www.togithub.com/googleapis/java-core/issues/657)) ([41a5120](https://www.github.com/googleapis/java-core/commit/41a51201a3712f71f6cf3be3c29db68360b2405f))
-   update dependency com.google.protobuf:protobuf-bom to v3.19.2 ([#&#8203;655](https://www.togithub.com/googleapis/java-core/issues/655)) ([eb6c037](https://www.github.com/googleapis/java-core/commit/eb6c03729af41e6d7bd9db80644b8ddfd22e78ec))
-   update dependency io.grpc:grpc-bom to v1.43.1 ([#&#8203;647](https://www.togithub.com/googleapis/java-core/issues/647)) ([275b882](https://www.github.com/googleapis/java-core/commit/275b882918f7625daeb3e98ab26b7b0a2f2cdb7b))

##### [2.3.3](https://www.github.com/googleapis/java-core/compare/v2.3.2...v2.3.3) (2021-12-02)

##### Dependencies

-   update dependency com.google.api:gax-bom to v2.7.1 ([#&#8203;640](https://www.togithub.com/googleapis/java-core/issues/640)) ([18e033b](https://www.github.com/googleapis/java-core/commit/18e033bdafe536a42ada9f93b0a2b502caea0bcf))

##### [2.3.2](https://www.github.com/googleapis/java-core/compare/v2.3.1...v2.3.2) (2021-12-02)

##### Dependencies

-   update dependency com.google.api:api-common to v2.1.1 ([#&#8203;632](https://www.togithub.com/googleapis/java-core/issues/632)) ([b9bb47a](https://www.github.com/googleapis/java-core/commit/b9bb47a0b0a6b132c516361d23750a92a32e53be))
-   update dependency com.google.api.grpc:proto-google-common-protos to v2.7.0 ([#&#8203;638](https://www.togithub.com/googleapis/java-core/issues/638)) ([74862a8](https://www.github.com/googleapis/java-core/commit/74862a8864eb7bffe6659d1e2a261dd5b934d6ff))

##### [2.3.1](https://www.github.com/googleapis/java-core/compare/v2.3.0...v2.3.1) (2021-11-15)

##### Dependencies

-   update dependency io.grpc:grpc-bom to v1.42.1 ([#&#8203;629](https://www.togithub.com/googleapis/java-core/issues/629)) ([85fcd99](https://www.github.com/googleapis/java-core/commit/85fcd99237d7526b1b373d07204c4114c49b08b8))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-vision).
@aribray
make MAX_RESULTS a constant
ad99af8 
Change-Id: I7d8c03fc9b4eb3419e7c52e108bb28b21f3276f5
@generated-files-bot
Copy link

generated-files-bot bot commented Feb 2, 2022

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@aribray
Merge remote-tracking branch 'origin' into aribray--flaky
e842dc4 
Change-Id: Ifc4bdfe3ca74790929b6f374f8a3cd7108956c66
@aribray
fix linting
adddc2c 
Change-Id: Idb04930eccc24634ac54cf401193807c48456ae3
@aribray aribray added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 2, 2022
@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2022
@aribray aribray added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 2, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 2, 2022
@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2022
@aribray aribray added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 2, 2022
@aribray
get build to rerun
e7328d1 
Change-Id: Ia75282ccb83d4da9d1d58eca93caaeb8ce529c82
@aribray
get build to rerun
e517728 
Change-Id: I6029e3d5389acac68ff49098868b1d1c244372e9
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2022
@aribray aribray added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2022
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2022
@aribray aribray requested a review from eaball35 February 3, 2022 17:13
@eaball35 eaball35 merged commit ede3abd into googleapis:main Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@kweinmeister kweinmeister kweinmeister approved these changes

@eaball35 eaball35 eaball35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: vision Issues related to the googleapis/java-vision API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vision.it.ITSystemTest: detectWebEntitiesIncludeGeoResultsTest failed

5 participants

@aribray @kweinmeister @eaball35 @yoshi-kokoro @renovate-bot