Merged
Conversation
shobsi
reviewed
Jun 11, 2025
| @pytest.mark.parametrize( | ||
| ("ascending", "dropna"), | ||
| [ | ||
| (True, True), |
Contributor
There was a problem hiding this comment.
why leave (False, True) and (True, False)?
Contributor
Author
There was a problem hiding this comment.
ah, just that they are orthogonal, and mostly just wanted to test both modes for each flag, but there isn't really any interaction
Contributor
There was a problem hiding this comment.
I see, might be worth adding a note (if not adding the combinations)
shobsi
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕