fix: move third_party.bigframes_vendored to bigframes_vendored#424
fix: move third_party.bigframes_vendored to bigframes_vendored#424gcf-merge-on-green[bot] merged 10 commits intomainfrom
third_party.bigframes_vendored to bigframes_vendored#424Conversation
This will avoid potential conflicts when run from a location that contains the commonly named `third_party` directory. Fixes internal issue 328781348.
GarrettWu
left a comment
There was a problem hiding this comment.
Just curious. If we want to avoid third_party, why can't we just remove it from the path?
We need it to signify that this code has a different copyright (isn't covered under Google CLA) per go/thirdparty/non-google3 policy. |
|
Note: please don't manually merge unless this has been synced to main. I'm using Edit: Update: |
This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.
This will avoid potential conflicts when run from a location that contains the commonly named
third_partydirectory.Note: I followed the instructions here: https://stackoverflow.com/a/17179022/101923 but I also had to add a
pyproject.tomlfile to support editable installations (see: pypa/setuptools#230 (comment)).Fixes internal issue 328781348.
🦕