feat: label query jobs with an bigframes-api-xx key indicating the Python API(s) used to construct it#55
Closed
feat: label query jobs with an bigframes-api-xx key indicating the Python API(s) used to construct it#55
bigframes-api-xx key indicating the Python API(s) used to construct it#55Conversation
22ca508 to
6f94f6f
Compare
b69b507 to
042045c
Compare
TrevorBergeron
requested changes
Sep 26, 2023
tswast
requested changes
Sep 27, 2023
Contributor
tswast
left a comment
There was a problem hiding this comment.
feat: seems an odd classification. This isn't a new feature as far as end user's are concerned, right? It doesn't allow them to do anything new.
17f0d53 to
db6f29c
Compare
bigframes-api-xx key indicating the Python API(s) used to construct it
tswast
requested changes
Sep 28, 2023
tswast
requested changes
Oct 2, 2023
tswast
reviewed
Oct 3, 2023
Change-Id: I2a201ff6f35e4c945177b2f504b60a3744e86a0d
* fix: generate unique ids on join to avoid id collisions
…e the length check logic
b9eda76 to
ca17ccf
Compare
4 tasks
Contributor
|
Closing in favor of the approach in #145 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I2a201ff6f35e4c945177b2f504b60a3744e86a0d
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕