feat: Add hasnans, combine_first, update to Series#600
Merged
gcf-merge-on-green[bot] merged 8 commits intomainfrom Apr 10, 2024
Merged
feat: Add hasnans, combine_first, update to Series#600gcf-merge-on-green[bot] merged 8 commits intomainfrom
gcf-merge-on-green[bot] merged 8 commits intomainfrom
Conversation
GarrettWu
approved these changes
Apr 10, 2024
|
|
||
|
|
||
| def to_bf_series(obj, default_index: index.Index) -> series.Series: | ||
| def to_bf_series(obj, default_index: Optional[index.Index]) -> series.Series: |
Contributor
There was a problem hiding this comment.
May worth add some docs how the default_index will be handled. Couldn't tell without reading code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕