Closed
Conversation
tswast
reviewed
Apr 30, 2024
|
|
||
|
|
||
| class GeoSeries(gpd.GeoSeries): | ||
| def distance(self): |
Contributor
There was a problem hiding this comment.
As we discussed in chat, let's do x and y properties to start to avoid complexities with binary operators / alignment.
Also, let's do a warnings.warn with a new bigframes.exceptions.PreviewWarning and add preview info to the docstrings to indicate that these features may change until we release them fully.
Contributor
Author
There was a problem hiding this comment.
Resolved on new PR today.
the geoseries class is a base for bigframes.geopandas.GeoSeries
tswast
reviewed
May 2, 2024
| import geopandas as gpd | ||
|
|
||
|
|
||
| class GeoSeries(gpd.GeoSeries): |
Contributor
There was a problem hiding this comment.
Instead of subclassing geopandas.GeoSeries, subclass your new third_party version of it.
tswast
reviewed
Jul 18, 2024
Contributor
There was a problem hiding this comment.
This should be in third_party.
Contributor
|
Thanks @DevStephanie for your help! I'm closing this in favor of #962. This PR gave our latest apprentices a great head start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕