Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

fix: don't raise UnknownLocationWarning for US or EU multi-regions#653

Merged
tswast merged 1 commit intomainfrom
tswast-unknown-US-warning
May 2, 2024
Merged

fix: don't raise UnknownLocationWarning for US or EU multi-regions#653
tswast merged 1 commit intomainfrom
tswast-unknown-US-warning

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented May 2, 2024

Follow-up to #609

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 331644525 🦕

@tswast tswast requested a review from a team as a code owner May 2, 2024 14:50
@tswast tswast requested review from a team and chelsea-lin May 2, 2024 14:50
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 2, 2024
@tswast tswast merged commit 8e4616b into main May 2, 2024
@tswast tswast deleted the tswast-unknown-US-warning branch May 2, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants