Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix(dbapi): allow rows to be fetched from scripts#387

Merged
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:masterfrom
tswast:issue377-dbapi-scripting
Nov 12, 2020
Merged

fix(dbapi): allow rows to be fetched from scripts#387
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:masterfrom
tswast:issue377-dbapi-scripting

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Nov 12, 2020

The is_dml logic is not needed now that we moved to getQueryResults instead of tabledata.list (#375).

Previously, the destination table of a DML query would return a non-null value that was unreadable or would return nonsense with DML (and some DDL) queries.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #377 🦕

@tswast tswast requested review from a team and pmakani November 12, 2020 23:08
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 12, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2020
@tswast tswast requested review from shollyman and removed request for pmakani November 12, 2020 23:09
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Nov 12, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit b899ad1 into googleapis:master Nov 12, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 12, 2020
@tswast tswast deleted the issue377-dbapi-scripting branch November 12, 2020 23:43
@mistercrunch
Copy link
Contributor

happy

@mistercrunch
Copy link
Contributor

Big thanks for making this happen, this enabled us to ship this: apache/superset#11904

We're planning more work around creating a great experience around BigQuery in Superset, looking forward to more collaboration!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants