AttributeError: 'effective_severity'

[jurancodes]

python-containeranalysis/samples/snippets/samples.py

Line 370 in 9d2f3a1

if v.effective_severity == Severity.HIGH or v.effective_severity == Severity.CRITICAL:

Hello!
When I use v.effective_severity, the script raise this error:

.venv\lib\site-packages\proto\message.py", line 515, in getattr
raise AttributeError(str(ex))
AttributeError: 'effective_severity'

I had it fixed by changing v.effective_severity into v.vulnerability.effective_severity because the effective_severity object is inside vulnerability, as seen in:

vulnerability {
  severity: 4
  cvss_score: 7.8
  package_issue {
    affected_cpe_uri: "cpe:/o:debian:debian_linux:10"
    affected_package: "linux"
    affected_version {
      name: "4.19.132"
      revision: "1"
      kind: 1
      full_name: "4.19.132-1"
    }
    fixed_cpe_uri: "cpe:/o:debian:debian_linux:10"
    fixed_version {
      kind: 3
    }
  }
  short_description: "CVE-2019-10124"
  long_description: "NIST vectors: AV:N/AC:L/Au:N/C:N/I:N/A:C"
  related_urls {
    url: "https://security-tracker.debian.org/tracker/CVE-2019-10124"
    label: "More Info"
  }
  effective_severity: 4
}

If this is correct, it may also need to update the documentation that reference it (if not done automatically):
https://cloud.google.com/container-registry/docs/tutorial-vulnerability-scan?#listing_high-severity_vulnerabilities

[askmeegs]

Thank you for opening this issue! I was able to reproduce the problem:

Traceback (most recent call last):
  File "/Users/mokeefe/dev/googleapis/python-containeranalysis/samples/snippets/megan/megan.py", line 31, in <module>
    result = find_high_severity_vulnerabilities_for_image(resource_url, project_id)
  File "/Users/mokeefe/dev/googleapis/python-containeranalysis/samples/snippets/megan/megan.py", line 22, in find_high_severity_vulnerabilities_for_image
    if v.effective_severity == Severity.HIGH or v.effective_severity == Severity.CRITICAL:
  File "/Users/mokeefe/dev/googleapis/python-containeranalysis/samples/snippets/megan/env/lib/python3.9/site-packages/proto/message.py", line 605, in __getattr__
    raise AttributeError(str(ex))
AttributeError: 'effective_severity'

And your suggested fix (adding .vulnerability) seems to resolve the problem. I will put out a pull request for the code sample. Thank you!