Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
This repository was archived by the owner on Feb 26, 2026. It is now read-only.

refactor: clean up CloudLoggingFilter#281

Merged
daniel-sanche merged 13 commits intov2_update_2from
refactor-names
May 5, 2021
Merged

refactor: clean up CloudLoggingFilter#281
daniel-sanche merged 13 commits intov2_update_2from
refactor-names

Conversation

@daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented May 4, 2021

Refactor PR in prep for the next minor release

  • use _ naming convention for added LogRecord fields, to prevent accidental user overide and avoid confusion
  • create separate guaranteed string representations for all fields (for StructuredLogHandler)
  • added helper functions to simplify code
  • removed some http_request fields (for now) that aren't fully tested across all environments

fixes #266

@daniel-sanche daniel-sanche requested a review from a team May 4, 2021 19:25
@daniel-sanche daniel-sanche requested a review from a team as a code owner May 4, 2021 19:25
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label May 4, 2021
@daniel-sanche daniel-sanche changed the base branch from master to v2_update_2 May 4, 2021 19:25
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2021
@daniel-sanche daniel-sanche changed the title [DRAFT] refactor CloudLoggingFilter refactor: clean up CloudLoggingFilter May 4, 2021
@daniel-sanche daniel-sanche merged commit 1e77860 into v2_update_2 May 5, 2021
@daniel-sanche daniel-sanche deleted the refactor-names branch May 5, 2021 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

standardize extras case

2 participants