Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings #5854

Merged
merged 18 commits into from
Sep 12, 2023
Merged

Remove warnings #5854

merged 18 commits into from
Sep 12, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 11, 2023

Removing warnings from the CI. The goal is to have warnings raise an error in the CI.

Gridplot warning will be handled in: #5873

xarray warnings will be handled in another PR, as I'm not sure about what to do with them right now:

UserWarning: rename 'x' to 'x' does not create an index anymore. Try using swap_dims instead or use set_index after rename to create an indexed coordinate.
UserWarning: Converting non-nanosecond precision datetime values to nanosecond precision. This behavior can eventually be relaxed in xarray, as it is an artifact from pandas which is now beginning to support non-nanosecond precision values. This warning is caused by passing non-nanosecond np.datetime64 or np.timedelta64 values to the DataArray or Variable constructor; it can be silenced by converting the values to nanosecond precision ahead of time.

holoviews/core/data/ibis.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #5854 (53b79e1) into main (9d74f7e) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##             main    #5854      +/-   ##
==========================================
- Coverage   88.35%   88.34%   -0.01%     
==========================================
  Files         310      310              
  Lines       63983    64001      +18     
==========================================
+ Hits        56529    56543      +14     
- Misses       7454     7458       +4     
Flag Coverage Δ
ui-tests 23.41% <10.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/core/data/ibis.py 76.54% <80.00%> (-0.34%) ⬇️
holoviews/core/data/pandas.py 93.47% <100.00%> (ø)
holoviews/core/util.py 86.07% <100.00%> (+0.04%) ⬆️
holoviews/element/chart.py 96.90% <100.00%> (+0.06%) ⬆️
holoviews/operation/timeseries.py 94.82% <100.00%> (+0.09%) ⬆️
holoviews/tests/core/data/base.py 100.00% <100.00%> (ø)
holoviews/tests/core/test_options.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

holoviews/core/data/ibis.py Outdated Show resolved Hide resolved
@hoxbro hoxbro marked this pull request as draft August 11, 2023 15:26
holoviews/core/data/xarray.py Outdated Show resolved Hide resolved
@hoxbro hoxbro marked this pull request as ready for review September 12, 2023 07:08
@hoxbro hoxbro merged commit 2d7d67a into main Sep 12, 2023
@hoxbro hoxbro deleted the remove_warnings branch September 12, 2023 07:16
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants