Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Add a more general fix for #127 (CPy #20007) based on #136. #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2015

Conversation

gsnedders
Copy link
Member

This gets stuff working with urllib.response.addurlinfo. See #127 and #136.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4800

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@gsnedders
Copy link
Member Author

@SimonSapin this may be of interest to you (maybe)

@SimonSapin
Copy link
Contributor

According to Kozea/WeasyPrint@e14653c , html5lib 0.999 already had a work around that was enough for WeasyPrint. Probably 18bc278.

@SimonSapin
Copy link
Contributor

Oh, looking closer, this is a similar but different work around. I don’t remember WeasyPrint being affected by that one, though.

@gsnedders
Copy link
Member Author

Yeah, from memory you for were just trying to get it to be more complete, rather than needing it yourself. I think?

@SimonSapin
Copy link
Contributor

Maybe. But to be honest I’ve kind of moved on from Python :)

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 3b3bc21 on gsnedders:addinfourl-20007 into 082c042 on html5lib:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling bf7da77 on gsnedders:addinfourl-20007 into 082c042 on html5lib:master.

@gsnedders gsnedders merged commit bf7da77 into html5lib:master Dec 12, 2015
@gsnedders gsnedders deleted the addinfourl-20007 branch May 7, 2016 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants