Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Store expected failures and move to py.test #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 12, 2015

Conversation

gsnedders
Copy link
Member

This is #182. Also includes a fair bit of clean-up. Nevertheless, this is enough to get all tests passed/xfailing.

@gsnedders gsnedders force-pushed the expected_failures_pytest branch from 1db202f to 9c46c98 Compare July 21, 2015 12:27
@gsnedders
Copy link
Member Author

Bah. The breakage is gsnedders/pytest-expect#2.

@gsnedders
Copy link
Member Author

And having thought I'd fixed that, I've now run into a bug in pickle on Py3.2/3.3… <_<

@gsnedders gsnedders force-pushed the expected_failures_pytest branch 2 times, most recently from 353bcf3 to ed67ab9 Compare November 25, 2015 15:14
@jgraham jgraham closed this Nov 25, 2015
@jgraham jgraham reopened this Nov 25, 2015
@jgraham jgraham closed this Nov 25, 2015
@jgraham jgraham reopened this Nov 25, 2015
@gsnedders gsnedders force-pushed the expected_failures_pytest branch from 77c8a22 to 63ecefa Compare December 3, 2015 03:00
@landscape-bot
Copy link

Code Health
Repository health increased by 0.06% when pulling 63ecefa on gsnedders:expected_failures_pytest into 52ba64e on html5lib:master.

@gsnedders gsnedders force-pushed the expected_failures_pytest branch from 63ecefa to 31767f4 Compare December 3, 2015 03:31
@landscape-bot
Copy link

Code Health
Repository health increased by 0.14% when pulling 31767f4 on gsnedders:expected_failures_pytest into 52ba64e on html5lib:master.

@gsnedders gsnedders force-pushed the expected_failures_pytest branch from 31767f4 to 82d1796 Compare December 3, 2015 03:41
@landscape-bot
Copy link

Code Health
Repository health increased by 0.03% when pulling 82d1796 on gsnedders:expected_failures_pytest into 52ba64e on html5lib:master.

@gsnedders gsnedders force-pushed the expected_failures_pytest branch from 82d1796 to dac1e0c Compare December 3, 2015 04:25
@landscape-bot
Copy link

Code Health
Repository health increased by 0.03% when pulling dac1e0c on gsnedders:expected_failures_pytest into 52ba64e on html5lib:master.

This also adds the mock package as a dependency for the testsuite,
as we need it to test our test code.
This was causing one of the tokenizer test failures.
Oh, and this adds PyPy3, while we're at it.

In short: we now test both with and without optional packages in tox
and fix Travis CI to test with optional packages under PyPy.
The test harness hasn't ever properly had an adapter that matches
the behaviour of PullDOM, and I have no interest in fixing this, so
let's simply drop support. AFAICT, nobody uses this.
Also enforce ordering of tests and test files, given nodeids for generators
depend upon iteration number, and pytest-expect relies on them.
Also add an assertion for symptom of html5lib#217 (without this the
testsuite goes into an infinite loop; this doesn't fix the cause
but it avoids the infinite loop happening!).
@gsnedders gsnedders force-pushed the expected_failures_pytest branch from dac1e0c to 082c042 Compare December 3, 2015 04:38
@landscape-bot
Copy link

Code Health
Repository health increased by 0.03% when pulling 082c042 on gsnedders:expected_failures_pytest into 52ba64e on html5lib:master.

@gsnedders
Copy link
Member Author

@jgraham I believe this is now in a position where it can land, with the history rewritten nicely. (Note GitHub's view appears to be sorted by author date, not by the actual parentage order…) So, uh, speak now or forever hold your peace, etc.

@gsnedders gsnedders force-pushed the expected_failures_pytest branch from c9ae3ea to 082c042 Compare December 7, 2015 13:30
@gsnedders gsnedders merged commit 082c042 into html5lib:master Dec 12, 2015
@gsnedders gsnedders deleted the expected_failures_pytest branch December 12, 2015 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants