Fix spider #294
Closed
Fix spider #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spider.py used both Python 2-only (md5) and Python 3-only (urllib) imports. Also, it didnt use a namespace when searching for links to spider, and did not read the robots.txt, preventing any spidering occurring. Fix exception occuring when robots processing removed items from list toVisit while iterating over the list. Add more output on stderr, and a main() which spiders yahoo.com
|
We could probably replace most of this with an existing library. |
Closed
|
Can we use |
|
Using |
|
As far as I'm aware, nobody's actually run it for years hence it being badly broken. We should probably just kill it at this point, as it likely has no real use. |
Closed
|
Given the previous comment, I'm going to close this out. I opened #349 to cover removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.