Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nord, Dracula, Solarized and Gruvbox themes #2170

Merged
merged 8 commits into from
Feb 3, 2024
Merged

Add Nord, Dracula, Solarized and Gruvbox themes #2170

merged 8 commits into from
Feb 3, 2024

Conversation

varbhat
Copy link
Contributor

@varbhat varbhat commented Dec 21, 2023

@hecrj , This PR is accordingly to how we discussed in Discord.

This PR does two things:

  1. makes color! macro return Color directly instead of invoking another function which does it. This way, we can use color! macro to create constant colors.
  2. Adds the following palette and themes:

@liigo
Copy link

liigo commented Dec 27, 2023

Dracula, not Drakula.
Most of them are just code syntax highlightings, not really GUI themes. I don't think they are fit well for Iced.

@varbhat varbhat changed the title Add Nord, Drakula, Solarized and Gruvbox themes Add Nord, Dracula, Solarized and Gruvbox themes Dec 27, 2023
@varbhat
Copy link
Contributor Author

varbhat commented Dec 27, 2023

@liigo , Except for Gruvbox, other themes are color palettes which are already utilised by many non code-syntax apps.
And please run the demo. These look great and according to me, these are good additions.

And @hecrj wanted other color schemes than default light/dark, so i think it might be worthy to consider this.

@liigo
Copy link

liigo commented Dec 28, 2023

@varbhat Color palettes can be used to create UI themes, but palettes themself are not UI themes. I suggest you create your own new themes, and give them new names, but don't use the name of those palettes. And maybe, they will reside in third-party crates. (After that for a long while, some of them that's very popular maybe have good chances to be merged into core crate as built-in themes, or replace existing light/dark themes.)

@varbhat
Copy link
Contributor Author

varbhat commented Jan 2, 2024

@hecrj , rustfmt'd. try again

@hecrj hecrj added this to the 0.12 milestone Jan 2, 2024
@hecrj hecrj added feature New feature or request styling addition labels Jan 2, 2024
@varbhat
Copy link
Contributor Author

varbhat commented Feb 3, 2024

@hecrj I am adding catppuccin (https://github.com/catppuccin/catppuccin) themes and palettes too.

Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🥳

@hecrj hecrj enabled auto-merge February 3, 2024 17:54
@hecrj
Copy link
Member

hecrj commented Feb 3, 2024

@varbhat Open a new PR for that one!

@hecrj hecrj merged commit 8781348 into iced-rs:master Feb 3, 2024
13 checks passed
@varbhat varbhat deleted the vbt/colorpalettes branch February 3, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition feature New feature or request styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants