-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Implement device arch comparison according to sycl_ext_oneapi_device_architecture spec update #12752
[SYCL] Implement device arch comparison according to sycl_ext_oneapi_device_architecture spec update #12752
Conversation
…device_architecture spec update This patch implements device AOT and host APIs for device architecture comparison in accordance to [spec update](intel#12259)
Adding @gmlueck as optional reviewer |
Sporadic issue unrelated to this patch, #12759 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
I did not look at the implementation in depth, but I have a few questions below.
sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
@aelovikov-intel, @intel/llvm-reviewers-runtime: friendly ping |
sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
@intel/llvm-reviewers-runtime, Andrei is on vacation, can someone review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to see the GMDID in the architecture enumeration! Awesome.
#if __SYCL_TARGET_AMD_GPU_GFX90a__ | ||
return ext::oneapi::experimental::architecture::amd_gpu_gfx90a; | ||
#endif | ||
#if __SYCL_TARGET_AMD_GPU_GFX90c__ | ||
return ext::oneapi::experimental::architecture::amd_gpu_gfx90c; | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dm-vodopyanov shouldn't these have been __SYCL_TARGET_AMD_GPU_GFX90A__
and __SYCL_TARGET_AMD_GPU_GFX90C__
(note the uppercase A
and C
) to match the definitions above ?
This patch implements device AOT and host APIs for device architecture comparison in accordance to spec update