[SYCL] Implement device arch comparison according to sycl_ext_oneapi_device_architecture spec update #12752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…device_architecture spec update This patch implements device AOT and host APIs for device architecture comparison in accordance to [spec update](intel#12259)
|
Adding @gmlueck as optional reviewer |
dm-vodopyanov
commented
Feb 18, 2024
Sporadic issue unrelated to this patch, #12759 |
gmlueck
reviewed
Feb 20, 2024
sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
|
@aelovikov-intel, @intel/llvm-reviewers-runtime: friendly ping |
gmlueck
reviewed
Feb 28, 2024
gmlueck
reviewed
Feb 29, 2024
sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
sycl/include/sycl/ext/oneapi/experimental/device_architecture.hpp
Outdated
Show resolved
Hide resolved
|
@intel/llvm-reviewers-runtime, Andrei is on vacation, can someone review please? |
gmlueck
approved these changes
Mar 5, 2024
cperkinsintel
approved these changes
Mar 5, 2024
fwyzard
reviewed
Aug 23, 2024
Comment on lines
+674
to
+679
| #if __SYCL_TARGET_AMD_GPU_GFX90a__ | ||
| return ext::oneapi::experimental::architecture::amd_gpu_gfx90a; | ||
| #endif | ||
| #if __SYCL_TARGET_AMD_GPU_GFX90c__ | ||
| return ext::oneapi::experimental::architecture::amd_gpu_gfx90c; | ||
| #endif |
There was a problem hiding this comment.
@dm-vodopyanov shouldn't these have been __SYCL_TARGET_AMD_GPU_GFX90A__ and __SYCL_TARGET_AMD_GPU_GFX90C__ (note the uppercase A and C) to match the definitions above ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements device AOT and host APIs for device architecture comparison in accordance to spec update